Will Holmgren
Will Holmgren
@echedey-ls thanks for taking the initiative! That issue is 7 years old and the pvlib documentation has changed a lot since then. I am not sure that 1:1 ports into...
Thanks @bmeyers! I think `requests` is already pulled into our test environments for another package. It's probably ok to make it an explicit requirement. The tmy module calls on urllib...
The resampling part of `standardize_time_axis` could be useful in more situations, but I don't know if it should be applied by default. What's the advantage of the `set_index` part of...
> What do you mean by calling pandas functions directly? Hopefully the discussion below is more clear. The first part of your function contains these lines to create a `DatetimeIndex`:...
I implemented a couple of PVDAQ fetch functions over in our Solar Forecast Arbiter project: https://github.com/SolarArbiter/solarforecastarbiter-core/blob/master/solarforecastarbiter/io/fetch/pvdaq.py https://github.com/SolarArbiter/solarforecastarbiter-core/blob/master/solarforecastarbiter/io/fetch/tests/test_pvdaq.py I based them on @bmeyers code but removed most of the `DatetimeIndex` handling...
I started using OrderedDict because I wanted my plots to consistently use the same colors when iterating over dictionaries returned by pvlib. And I thought "well DataFrames have ordered columns...
Apparently I added this function 9 years ago during a large refactor, perhaps in an aborted effort at DRY code, but never used it. Tests were hardly a thing at...
> Function pvlib.irradiance.poa_horizontal_ratio is being used in example irradiance.ipynb Those notebooks are not maintained and likely will be deleted in the future. > also what is the following checking for?...
If it's already useful for PV modelers that's fine with me. I am not picky about what goes into `iotools` but I don't want it to be a dumping ground...
`Location.tz` goes way back to the very earliest days of PVLIB_Python's [pvl_makelocationstruct](https://github.com/pvlib/pvlib-python/blob/89cc1fcbd3eee11fe9ae179c9275a24c04820745/pvlib/pvl_makelocationstruct.py#L7) and was used by functions that accepted this struct and calculated solar position with it. A couple of...