Results 193 comments of Jeremy Whitlock

This file is generated, I'm not sure how to get `@otris/jsdoc-tsd` to generate this. Let me do some digging.

First off, thanks a ton for taking this on. I'll review this more in depth ASAP.

@chris-armstrong Thanks again for doing this, and if you're still willing to help me get this ready to merge, I'd love to use it. I know you said you don't...

Which version of `json-refs` are you using? Can you give me a real reproduction recipe so that I can debug locally?

@kenisteward Sorry about that, I've not done much OSS lately. But I did look into this and I _think_ it's because the unresolved JSON References are invalid. According to the...

I've verified this is indeed the case by using the `json-refs` CLI _(`json-refs resolve -w` will treat warnings as errors. Otherwise, warnings are ignored but resolution still doesn't occur)_: ```...

How would **you** like this to work? I'm all ears on making this better, and more intuitive.

I agree. I was thinking of a flag, like `options.resolveRefsWithProperties` that has a couple different options: * `false` _(default)_: Do not replace the values _(this is the current mode)_ *...

This is indeed a bug, I apologize. I agree that the reference details for both should have `circular: true`.

This is intended behavior, and is documented here: https://github.com/whitlockjc/json-refs/tree/master/docs#resolution Long story short, circular references are a problem for many tools and so we will leave circular references as-is in the...