Isaac Whitfield

Not sure if the count variable is unnecessary

1

You already have `index` in scope, it seems like `count` is redundant and can be removed. Instead I believe you can check `index === items.length - 1`?

The package details say anything above Elixir v1.0, but there are a number of stdlib functions used which were introduced in v1.3 (`String.trim*`). Either the details should be updated, or...

Standardize how middleware implementations will be distributed

1

Right now there are two places for middleware; one in the `middleware` directory in the root, and another under the `::middleware` module in the `gotham` code. Since this is a...

It seems that there may be some room to remove the `NewMiddleware` trait. I think this would be beneficial as it makes creating a Middleware easier, and removes the need...

Support src/install in the same project configuration

2

Disclaimer: I'm new to using `clib` so apologies if this has been visited in the past and I've missed it. From what I understand, if you provide `"install"` in your...

I took a look through existing issues and couldn't find anything, so figured I'd file this just for tracking purposes. Right now the documentation states that: > NOTE: Websocket API...

Any plans on releasing to Maven Central/JCenter?

2

This would provide easier integration for both Maven and Gradle projects

Add `map` like functionality to read guards

1

One feature that the sync features of Tokio have is the ability to `map` guards such as `RwLockReadGuard`, which makes it possible to (e.g.) return a reference to a value...

Add a very basic LRU cache clear implementation

3

There's a really "easy" way to implement very basic LRU using LRW, by adding a hook to the LRW implementation to update touch time when a key is accessed and...

There are many other popular runtimes besides Tokio, we should add modules for these runtimes too. The two in mind are `smol` and `async_std` but there are probably others. At...