Catherine

Results 1906 comments of Catherine

There's this issue with it: > WARNING: Unfortunately, there are a number of known problems with Cork. I have zero time to work on the library since I'm currently busy...

@tpimh Sure. Rotate a triangle. ![screenshot_20170319_154656](https://cloud.githubusercontent.com/assets/54771/24082314/7f2d2fb4-0cbb-11e7-9d8c-a348ef8bd72d.png) ![screenshot_20170319_154709](https://cloud.githubusercontent.com/assets/54771/24082315/82a95e7e-0cbb-11e7-90c1-bedb49ab190f.png)

Thanks, I've cherry-picked most of this PR. Could you please rebase it so we can discuss the rest? There are a few things I'd like to see changed. The main...

@rpavlik Also, looks like tests crash on Windows now. Could you please take a look? https://ci.appveyor.com/project/whitequark/solvespace/builds/27299022

Looks like the crash is caused by "Range-for conversions and improvements. NFC."

@rpavlik This PR still fails on Windows.

Merged a few more commits from here. In "Simplify returns and booleans. NFC.", most of the changes make the code less readable, and a few comments no longer explain what's...

Merged everything except FindIndex changes. Do we really have no better approach here than returning -1 if it's not found? Morally it seems like FindIndex ought to return size_t.

Yeah that'd probably be fine.