Chris White
Chris White
We should see what problems we have migrating to TOSS4 before we are forced to.
This was missed in a previous PR.
> Edit: This does actually bring up a good point in your thorough comment. We are setting time and cycle but not dt (via `MFEMSidreDataCollection::SetTimeStep`). @jamiebramwell, does the `dt` every...
When viewing output in visit, time is always 0.
It is easy for tests to not be guarded by `ENABLE_TESTS`. Since this is not a normal way for a developer to build, downstream users will be the first to...
We should have the ability to stop a simulation on a certain cycle. This would be useful for debugging and testing purposes. For example, our restart tests could run until...
Cycle is loaded from previous run here: https://github.com/LLNL/serac/blob/4c19ba966aeed4bc73b3ac5513fbd45eed370451/src/drivers/serac.cpp#L162 but the time step is not adjusted here: https://github.com/LLNL/serac/blob/4c19ba966aeed4bc73b3ac5513fbd45eed370451/src/drivers/serac.cpp#L201-L203 This should also be something like this: ``` // Initialize/set the time information...
We should have the ability to stop a simulation on a certain time. This would be useful for debugging. Command line option should be named `stop-time`.
Noticed by @jamiebramwell in a Smith update. We should also add one to Smith if its not there and make sure both exist together.
There are a lot of duplication in the exported config files in Smith that can be removed and leveraged fully from Serac. For example, we should just be using the...