Andrea Leopardi

Results 355 comments of Andrea Leopardi

Hi @ttarann thanks for the report. Blank as in `""`?

I don't think we should ignore all whitespace but we should likely ignore `""`, yes. Want to send up a PR? šŸ™ƒ

Hi @nsweeting ~are you using HTTP/1.1 or HTTP/2?~ Strike that, it's in the title. Yeah I think we can support this. Want to try sending a PR for this? šŸ™ƒ

No, this is not a known failure mode and could definitely be a bug. See the diagram in https://datatracker.ietf.org/doc/html/rfc9113#section-5.1: ![CleanShot 2024-09-19 at 13 50 42@2x](https://github.com/user-attachments/assets/fd5ef2e3-6cf9-47ca-aa63-d9d8c923a872) We get to the `:half_closed_local`...

Oh, mh. Yeah that totally makes sense: we don't receive anything from the server and the request just stays open. We can't even really do timeouts *within* Mint because connections...

Mh. I understand the need for this but I’m a bit worried about having a custom way of tracing. An alternative would be to have `telemetry: true | false` and...

There are some things that you cannot know that Mint is doing, like hostname resolution or HTTP/2 internals, so maybe it could make sense for that. We've been generally against...

> I'd definitely prefer a custom function over telemetry. Why? To keep it localized and not go through the global handlers ETS and stuff? > I don't know if Mint...

> if the goal is to eventually include this in Erlang/OTP, we can't have telemetry there. Ah yeah fantastic catch. Ok, then let's go with a function! > It would...

A good callout is that passing the conn around without being able to update it is mostly something to read the conn. In that case, maybe it would be enough...