Andrea Leopardi

Results 355 comments of Andrea Leopardi

> Usually when you deal with a secret you would want it to be wrapped as soon as it enters your app - when you load it from the database,...

If we define a `Mint.Redactable` protocol we could implement it for strings, functions, and `%Mint.SensitiveValue{}` and then call it on basically everything we think could be sensitive—headers, payloads, URIs, whatever....

If you have ```elixir # In the Mint module def redact(value) do fn -> value end end ``` then you don't have the benefit of "custom redacting" that you talked...

What would `:deadline` be, a time in the future that the request needs to be done by? As for retries, it's hard. Do you want to yell at people if...

> I'd keep it orthogonal and dumb Yeah it probably is reasonable enough. 🙃 Sounds good.

Yeah good point, the steps can add to the total timeout. Maybe I’m thinking this: we can add a timeout to Req that translates to the actualy network timeout (so...

@solnic @sl0thentr0py we should be able to close this out, right?

I would try to stick as close as possible to `Map`/`Keyword` APIs for familiarity. So, `update` would mean default value + function, `update!` expects it to be there. `Map`/`Keyword` don't...

If you use `Process.info(pid, :parent)` instead of the `$...` stuff it usually works *much* better 😬

I don't think so because `nimble_ownership` doesn't know about `$callers` and friends—I did this one layer up in Mox for example: https://github.com/dashbitco/mox/pull/164