Gang Wu comments

Results 304 comments of


                                            Gang Wu

Make ColumnPath immutable

It seems that you need to run `mvn spotless:apply` to make the CIs happy.

Make ColumnPath immutable

BTW, could you please create an issue to explain why do we need this change? https://github.com/apache/parquet-java/issues/new/choose

[WIP] Add support for geometry type

Thanks for implementing this! I will hold my review until the spec has been finalized.

[WIP] Add support for geometry type

https://github.com/apache/parquet-format/pull/240 is still under review and subject to change. I think we can wait until it has been finalized. @dongjoon-hyun

[WIP] Add support for geometry type

If 2.1.0 will be released around January 17, 2025, then I think yes.

[WIP] Add support for geometry type

Yes, the discussion of Geometry type on the Iceberg and Parquet side took longer time than expected. I don't think it will be closed soon. Moving it to 3.0.0 seems...

Orc unable to find dependencies, even when they exist

Is it simpler to introduce a `ORC_PACKAGE_KIND=conda` mode like `conan` and `vcpkg` so Apache ORC does not install custom findXXX modules at all? cc @h-vetinari

Orc unable to find dependencies, even when they exist

Yes, using CONFIG mode is considered as well. I agree that `ORC_PACKAGE_KIND` makes things more complicated. I was also thinking of totally removing the legacy `FindXXX.cmake` modules to make the...

ParquetFileWriter in invalid state after network outage in end(metadata)

Thanks for reporting this! Do you want to create a PR to fix this?

Invalid ColumnVectorBatch access when fetch from std::vector which construct from a loop with RowReader::next

I suspect that `c_mktsegment` column has some nulls in it. You might need to check `hasNulls` and `notNull[i]` to confirm.