Gang Wu

Results 304 comments of Gang Wu

It seems that I cannot execute `-Db_sanitize=address,undefined` on my MacOS M1.

> ERROR: Linker c++ does not support sanitizer arguments ['-fsanitize=address,undefined'] I got the above error. If I removed them, I see some compiling error from boost like below: ``` FAILED:...

I have successfully reproduced it without meson. Simply run `cmake .. -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_TESTS=ON -DARROW_ORC=ON -DARROW_USE_UBSAN=ON` ``` [----------] 3 tests from TestORCWriterNoConversion [ RUN ] TestORCWriterNoConversion.writeNoNulls [ OK ] TestORCWriterNoConversion.writeNoNulls (87...

``` diff --git a/cpp/src/arrow/adapters/orc/util.cc b/cpp/src/arrow/adapters/orc/util.cc index 6974faae59..68d062f125 100644 --- a/cpp/src/arrow/adapters/orc/util.cc +++ b/cpp/src/arrow/adapters/orc/util.cc @@ -212,7 +212,10 @@ Status AppendTimestampBatch(liborc::ColumnVectorBatch* column_vector_batch, const int64_t* seconds = batch->data.data() + offset; const int64_t* nanos =...

That's weird. The `GetFieldMetadata` function does not call `orc::TypeImpl::getTypeByColumnId` internally. Even the ORC library does not call it internally. ``` Result GetFieldMetadata( const liborc::Type* type) { if (type == nullptr)...

I tried to reproduce it on my side with ASAN enabled. It didn't fail but got the suspicious output: ``` [ RUN ] TestAdapterRead.ReadIntAndStringFileMultipleStripes mimalloc: warning: unable to allocate aligned...

Perhaps a fix is required to use the same orc version, either built or installed.

Unfortunately I'm not familiar with `pkgconfig` so it may still be the case in the near future. Is there any workaround?

Yes, usually the PoC implementation cannot pass CI due to dependency on an unreleased format. I'd like to include https://github.com/apache/parquet-format/pull/240 to the next release as well.

Let me close this issue. Thanks for checking this @alamb!