Bill Goehrig
Bill Goehrig
> Does upgrading to TypeScript 5.3.3 necessarily also involve upgrading the eslint plugin? @pmconne Yes. The new TS versions include breaking API changes that necessitate changes to @typescript-eslint/parser.
Also worth noting that TypeScript updates almost always include a lot of lint fixes, even if no eslint plugin update is required, because most new TS releases these days significantly...
> I reviewed the .api.md files. Reviewing all 240 changed files seems infeasible. @pmconne FWIW, most of the lint fixes were trivial no-unnecessary-type-assertions fixes, so looking at these changes in...
> Ideally we could remove all such rules and let the formatter worry about formatting and the linter worry about code. Many of those rules were removed in the latest...
This is blocked by https://github.com/swc-project/swc/issues/9688
> there's a pattern that all these errors pop up **after** a certa-run test suite is finished That is by design. I [implemented this error](https://github.com/iTwin/itwinjs-core/blob/06313ff2dc8671959008c377d92437e3bbe2f57a/tools/build/src/mocha-reporter/index.ts#L91) because our test runner will...
Sorry for the delay in reviewing this. I've approved #8020 because that seems like an appropriate workaround for now, but I do still think these failures are possibly a symptom...
Re-opening this, as we need to identify _some_ solution to locks not being released after undo, and I'm not convinced this can't be done at the platform level