Bernd Weymann

Results 24 comments of Bernd Weymann

> @weymann - while waiting for some opinions and/or guidelines, consider if you can reduce number and/or size of pictures further. Some might be replaceable by textual descriptions? Compressed pictures...

I removed kar file from Marketplace but I cannot explain what is causing the problem. I'm building jar & kar against latest openhab-addons repo without referecing a certain snapshot. Both...

Just removed the link from the Marketplace posting. It's still available in my [repo](https://github.com/weymann/OH3-SolarForecast-Drops/tree/main/3.4)

It's one year later but I see still the necessity in the enhancement. There's a request https://github.com/openhab/openhab-addons/issues/12783 to enhance the MyBMW binding with a `distance-from-home` channel. Use case is to...

@wborn Moving protobuf classes out of org.openhab package doesn't work. Still get all errors [ERROR] com.daimler.mbcarkit.proto.VehicleCommands.java:[6] An author tag is missing Maybe I should be more specific: It's generated sources,...

Work in progress removed. Binding looks pretty stable after [testing by community](https://community.openhab.org/t/mercedes-me-binding/136852/182) ~~@openhab/maintainers still struggeling with proto java classes provided by Mercedes / Daimler which are causing many checkstyle issues....

> @weymann this is marked as WIP for some time and that is perfectly fine. With 150+ changed files, it would take multiple review rounds i guss and some extensive...

> 163 000 lines of code ! Who will have the courage to start the review of such a big PR ? @lolodomo Keep calm and start review! code without...

> * the 3rd party folder was not reviewed, as there seems no point in reviewing all that code > * i cannot asses if the *.proto files are ok,...

I'll do as you suggested. Was developed in parallel to Mercedes binding so I can imagine some similar findings. Put "WIP" in headline and I'll remove it as soon as...