James Wetzel comments

Repositories
Issues
Comments

Results 15 comments of


                                            James Wetzel

0.2.29 rc

Hi @vsoch - I think this PR was prematurely closed. When I first saw that this was closed, I did notice that #204 had been merged, but on closer review,...

0.2.29 rc

Sounds good. I'll work on it next week. Is it okay if I base it off of #234 or would you prefer it be based off of master?

0.2.29 rc

Great! PR #237 created to merge these changes into #234.

Photometric Interpretation of the dataset is YBG_FULL_422 [...] You may need to change the Photometric Interpretation to the correct value

Unfortunately I haven't seen this issue - and don't think I've dealt with YBR_FULL_422 images at all. That said, I noticed that in [clean.py](https://github.com/pydicom/deid/blob/48057c4e7a903c80dfd1c17f84eba3de6d9e3fad/deid/dicom/pixels/clean.py#L294) deid is switching the PhotometricInterpretation to...

Minimum Required Versions - Python >=3.7; Numpy >= 1.20

Yep. Thank you!