Wes Lowrie

Results 16 comments of Wes Lowrie

The line with 'int(os.environ.get('OMP_NUM_THREADS',1))' gets the value set by the environment variable or if not set defaults to 1. That would be nice if openmp could handle the work array...

@mandli > I wonder if instead of using the environment variable that there is some way to fetch the desired number of threads. Are you wondering if we can query...

> Does compiling the code with -fopenmp make anything slower? > Is it at all probable that users will try to compile the code on a system without OpenMP and...

I'm trying to have a default behavior when the openmp env variable `OMP_NUM_THREADS` is unset. The problem is the line in step3ds(): `!$ nthreads = omp_get_num_threads()` sets `nthreads` to the...

@ketch Yes no problem. I'll update step3.f90 as well. We should find a resolution to the case where `OMP_NUM_THREADS` is unset or there is no openmp on a system. One...

I have added a modified step3.f90 to include OpenMP as done in classic clawpack. I tested this with the euler_3d, Sedov.py and the regression test within the folder. OpenMP appears...

@mandli yes you are correct, and it is a problem. Not only are the aux arrays larger, but the work array is larger as well set in `_allocate_workspace()` in `solver.py`....

I made some changes, and I think it gives a desirable default behavior. The python code checks if the `OMP_NUM_THREADS` variable is set, if not it gives a warning and...

@mandli I'm not sure about the default logging levels. Do I need to do anything more than add a line like this: `warnings.warn("...")` for default logging?

@mandli I modified it so it uses the PyClaw logger as suggested. It writes the warning to the console and the log file with this method. I did have to...