Wes Todd

Results 397 comments of Wes Todd

Here are the lines in question for reference: https://github.com/pillarjs/router/blob/d3a598d3afec5bf55d683f25887bbbf8fd65e4f8/index.js#L180-L183

Even with the service worker use case, the router is for routing. Let the layer above handle what requests to respond to and how. I also agree that the router...

Anything blocking this? I would love to replace what I have been doing in middleware with these new events.

Ahh, sorry @dougwilson I didn't open the "outdated diffs". I completely agree with the comments, and am anxiously awaiting this merge :) Thanks for the good work @hacksparrow!!

TBH I think you have to do bubbling for `layer` events, if you don't I think the behavior will be unexpected. That being said, multiple start and end events seem...

To address the cases that I would use this for right away, here are two I can think of: 1. Unbind events on the front-end when the NEXT `handlestart` event...

So I am circling back on this, and after re-thinking it I do not think anything other than the `layer` event should be included. Here are my thoughts: 1. There...

> Hi guys! so is this still happening? :) If it is, as I said in my last comment, I would hope we just go with the layer events. That...

Ok, no comments. But @dougwilson it looks like I am not an owner on this org so cannot close this. 🤷‍♂️

@dougwilson It looks like just adding me to the tc group is not enough to be able to close issues. Seems like there must be some settings to make that...