Wes Todd comments

Results 397 comments of


Wes Todd

Deprecate arity check in favor of explicit error handlers

I guess it does remove the version where you package them up in an array. So it is not exactly the same, but again, I argue that this loss is...

Deprecate arity check in favor of explicit error handlers

Do you have any ideas on how to keep this feature but also remove the arity check? That is the problem I am having, I cannot think of a clean...

Deprecate arity check in favor of explicit error handlers

We could introduce a new api which wraps error handlers, something like: ``` app.put('/foo/:id', [authnMiddleware, app.errorHandler(authnErrorHandler)]) ``` Or we could add a property: ``` authnErrorHandler.isErrorHandler = true app.put('/foo/:id', [authnMiddleware, authnErrorHandler])...

Deprecate arity check in favor of explicit error handlers

I had one other idea for this last night. What if we expose a new abstraction, a `Stack`, which would be a very light weight wrapper around a set of...

Deprecate arity check in favor of explicit error handlers

Exactly, that is what I was relating this idea to as well. Does this sound "promising" (pun intended) enough to build a PR around? IMO it is better than the...

Deprecate arity check in favor of explicit error handlers

Ok, I was thinking more about what this could look like, and this is what I came up with: ```javascript var flatten = require('array-flatten') var slice = Array.prototype.slice class Stack...

Deprecate arity check in favor of explicit error handlers

> One con with Symbol is that it might not work in all Node.js versions we support It would be in what we plan to support in `5.x`, it [is...

Deprecate arity check in favor of explicit error handlers

Ok, I pushed a version which is compatible with the idea above. The additions to support a new `Stack` abstraction were small because I kept the main implementation as a...

Deprecate arity check in favor of explicit error handlers

Ok, I updated things on that repo. All that is left is moving the repo. @dougwilson do you have any other changes you want on that repo? If not can...

Deprecate arity check in favor of explicit error handlers

I am pretty confident that this abstraction would be applicable outside of just express. The other frameworks are one use case, as well as compatibility layers written against express (like...