William Escande
William Escande
> you only consider actively adding white spaces at the end of the line, but git prints spaces in red on modified lines even if it's not being actively added,...
The test pass because [the source](https://github.com/dandavison/delta/blob/af84d5c7019f4481a6d64112d74e4eae727c4bd1/src/delta.rs#L68) is `Unknown`, so the output is [replicated direclty](https://github.com/dandavison/delta/blob/af84d5c7019f4481a6d64112d74e4eae727c4bd1/src/delta.rs#L72) The test would have failed if there was no newline [here](https://github.com/dandavison/delta/blob/af84d5c7019f4481a6d64112d74e4eae727c4bd1/src/delta.rs#L859) something like this: ```rust const...
Hi I forgot about this me too :) Hi @amtoine , I rebased the PR in order to solve the merge conflict in `src/edit.rs` (it was a trivial fix) but...
A few hours laters... I added a new small test (a subset of the whitespace_complex) + fix the` test_infer_edits_9` Current patch still fail `test_infer_edits_14` and the `test_whitespace_complex_error`. But it is...
And done :heavy_check_mark: ! We are back to the visual from the first comment of this PR. and all test are green :tada: I fixed the `test_infer_edits_14`. Test was failing...
> i could not find anything looking like color control in your changes, do you know where this is? I do not know :/ > for instance, in a GitHub...
Sorry, github notification are not appearing in my main mail box and I missed your comment. I resolved all of them. Feel free to take another look and add more...