wes adams

@Siiiimon - sorry. this is my first ever attempt at contributing. i didn't realize that we should claim work before starting. anyways, i have a starting attempt here: https://github.com/helix-editor/helix/pull/4682 looking...

the linter pointed out my poor coding style pushed 2nd attempt

@Siiiimon - thanks for the feedback - i'll definitely be implementing your suggestions EDIT: wow, i was really overthinking the question below. i got it all figured out. the solution...

can this be broken into multiple issues/fixes? i'd like to attempt a fix for 1. Rendering on top of the cursor and obstructing the current editing line, commonly happens with...

i pulled `master` and tried to repro number 1, the overlap issues that i am sure i used to encounter... and i have to agree! looks like this was fixed.

> I haven't looked at this yet but also see #4635 which I think will have some overlap implementation-wise Thanks. I'll definitely look into that work. This PR is 100%...

i think the only optimization left is to search only the visible text for matches versus the entire document i've given this a little effort, but would welcome any feedback...

> Just a couple comments: > > * The matches should not be stored on the editor, they should be stored on the document or (even better) on the view...

> Is the color here the same as selections? Might need to difference between those. > > A feature I would like is to highlight words that match the current...

this one is ready for a closer look guys i think the behavior is close to what @pascalkuthe outlined in the comment above @the-mikedavis @pascalkuthe