axp
axp
@Lancern Added `CaseOpKind_NE` and `buildCaseNoneStmt()` to handle the unreachable statements. Thanks for pointing out it!
It becomes a little complex when we consider `case` across scope, the current definition of `SwitchOp` is not enough to express the semantics. The definition assume the size of case...
Appreciate for the suggestions! This pr is ready for review now. @Lancern @bcardosolopes
Comments addressed. Found some new corner-case, so rewrite some function and add a few UT.
Hi, this pr is ready for review, thanks~
@bcardosolopes Yes, just be a little busy recently, I will update the pr and request review form you later days, thanks~
Just found this issue when construct test case, thank you for advice, I will keep focusing on my unfinished work :)
I know it's a verification error about SwitchOp, do we have some methods to print more information (e.g. the illegal cir body)?
I'm still working on https://github.com/llvm/clangir/pull/528, and I feel these problems should be resolved in a unified solution. So I need to do some more test, will update my proposal soon...
I have a proposal to fix this issue by modifying the definition of `SwitchOp` # What's the limitation of current `SwitchOp`? Current `SwitchOp` have a list of `caseAttr`, one `caseAttr`...