Wen Bo Li

Results 166 comments of Wen Bo Li

Clarification -exclude_modules with modules that use augmentation.

Thanks Hans for the detailed report, I reproduced it using `compress=false`, and if I add another container under `augmented-top` I can reproduce using `compress=true`. The root cause of this issue...

when creating a keyed list entry, the reference node of the key should be created first

This seems to be implemented today whether or not `compressPaths` is true. From `unexampleoc/oc.go` ``` func (t *OpenconfigPlatform_Components) NewComponent(Name string) (*OpenconfigPlatform_Components_Component, error) { // Initialise the list within the receiver...

when creating a keyed list entry, the reference node of the key should be created first

Ahh oops, my mistake not noticing the config node underneath. I'm happy to keep this open as a low priority item (since there has not been discussion since).

Add PathAndStruct helper for generated non-leaf PathStruct types.

When generics is ready a better design for this might be just to provide the function ```go func ygot.GoStruct[T GoStruct](PathStruct[T]) T {} ```

Generate Name() method for all GoStructs

Thanks Dan, that's what I'll do. I'd like to add this after the `util` packages are split. This will go to the `gostruct` package.

Handle custom validate method on fakeroot

Created, thanks for the change.

Handle custom validate method on fakeroot

Sounds reasonable to me if there is a need for it from the community.

Refactor how path structs are split.

FYI https://github.com/openconfig/ygnmi/tree/main/pathgen is the future place for ypathgen and pathgen.go here will eventually be deleted. I will upstream this change after merge.

Refactor how path structs are split.

> Good point about generating the empty files -- it's a bit messy from the perspective of non-bazel users to have a bunch of files sitting around, should we consider...

Refactor how path structs are split.

Generics isn't actually being used in ygnmi's path struct generation package, so I think we can remove `ypathgen` now. Filed https://github.com/openconfig/ygot/issues/720 Just verified that we can actually have circular imports...