Wen Bo Li

Results 166 comments of Wen Bo Li

I believe this is due to `goyang` not processing "augment" statements inside "uses" statements at all. Is it possible for you to change this to a module-level augment to work...

My personal take is that this doesn't need to be part of the v1 milestone since it doesn't introduce any backwards incompatibility issues, and is likely a corner case not...

This issue is only relevant when unmarshalling JSON. When unmarshalling a `TypedValue`, `YANGEmpty` and bool are indistinguishable from one another in their encoding.

It's actually not this PR, but rather this comment: https://github.com/openconfig/ygot/pull/467#discussion_r707869638 I'm wondering if you think it's worth splitting the util package up into these packages in order to make the...

Hi Jason, thanks for your changes. It seems that ygot doesn't have good support for extensions (no helpers), and as a result I see two immediate concerns (due to this...

_**TLDR**_: In any case, I agree that we should add both duplicate-check and overlap-check functionality into proto generation, if you don't mind. Then, assuming the extensions get pushed (and there...

Good eye, nested uses statements definitely makes sense as a use-case to me. Added openconfig/goyang#113 to test extensions for nested use statements. List of Error Checks: - duplicate `field-number` extensions....

@jasonewang btw I'm working on getting your changes in.

I have the change ready now, though it's dependent on https://github.com/openconfig/goyang/pull/183.