Wen Bo Li

As discussed I agree with the design choices wholly. Using `LeafDetails` within `Directory` will require some mechanical refactoring in `ypathgen` that actually makes its code cleaner, so it's a welcome...

May want to consider how to fit the IR to allow adding a pluggable callback when generating code: https://github.com/openconfig/ygot/issues/522

@robshakir I'm going to pick this up from your branch at https://github.com/openconfig/ygot/tree/restruct-ygen-interface and https://github.com/openconfig/ygot/tree/ygen-ir-langmapper.

So a few proposals to reduce the complexity of the design as well as to allow for custom user passes: * All code should be put into a template structure...

@robshakir I think the "IR generation residing in an internal package" might be contentious, so I want to raise your attention on this one. In particular currently-exported names like `MappedType`...

> > So a few proposals to reduce the complexity of the design as well as to allow for custom user passes: > > > > * All code should...

#247 is an interesting case that this should handle. Maybe just generating an initialization routine that sets `default` values on enum fields within `GetOrCreate*` and `New*` would be sufficient, instead...

Extending it to all other values is talked about in #101

So I think that #101 is the right discussion for this question and should be resolved by its resolution. I think we shouldn't look at only providing default support for...

Confirmed that this an issue with the given OC paths. `sid-id`'s DYNAMIC enum value is ungenerated.