Wen Bo Li

I see this: "// TODO(robjs): Implement unmarshalling annotations" @robshakir

Thanks @sysbot for looking into this. I'm also relatively new to this codebase; however, I do see this working and I probably would go about it the same way. Sorry...

I think this could make sense as a workaround where YANG files use unsupported types. Another solution would be to introduce an error type to distinguish these errors from other...

This is a TODO item in the code. I will take a look at this.

So what needs to be done here is that `protomap.ProtoFromPaths` needs to be able to recursively populate fields. Currently, the function only supports unmarshalling direct children, and skips the rest....

@vcheny

Thanks for reporting this issue. Unfortunately I believe there is no option to coalesce deletions. I think this makes sense as an option to support for `ygot.Diff`. One way to...

@robshakir I believe this is intentional in order to give 0 to UNSET? There is no need for actually using the values since the name can be used?

Hi Soumik, this is where the JSON marshalling routine skips over empty containers. https://github.com/openconfig/ygot/blob/2713b986ad5a22464ae5e72e919be9f519466246/ygot/render.go#L1078-L1080 Like Rob said, I think it makes sense to add a struct tag when generating code...

This looks good! I like and agree to the design of having `goStructName()` and `resolveKeyTypeName()` (the function parameters to `buildDirectoryDefinitions`) as part of a configuration passed into `GetDefinitions`. The nuance...