Wen Bo Li

Results 167 comments of Wen Bo Li

@jasonewang Do you think you could consent again at #549? Thanks. For some reason googlebot needs another consent if the PR submitter changed.

@robshakir I realized I can just push to Jason's fork. When you have time could you take a look? changes at ygen/protogen.go

Could you comment on what use case you're intending to use this for? I'm thinking this has to do with the fakeroot but I think understanding the use case will...

The reason is because we're omitting generating options for oneof fields. @robshakir do you know if this a known limitation? See here how options are just ignored for oneof fields...

Sounds reasonable, we'll get back to you on it.

Hi songfeijun, your proposal sounds reasonable, I'm open to reviewing your changes if you wish to make this change.

There is a `ygot. MergeStructInto ` ([godoc](https://github.com/openconfig/ygot/blob/master/ygot/struct_validation_map.go#L507)) that allows you to merge the fields of a different struct into the original GoStruct. Does that do what you want to achieve?

I agree that it's inconsistent that, as in your referred commit, both `=` and `]` are escaped, despite the former being unambiguous, and `[` is not escaped even though it's...

Adding to 1.0 since this is backwards-incompatible.

We've started on a [design doc](https://docs.google.com/document/d/1q6D05VRkVmFhta18buqoG3Pk2dZ_W_yc5ct9-WsZZ38/edit?usp=sharing), feel free to add comments and concerns.