wendy5667 comments

Results 5 comments of


                                            wendy5667

feat(websocket): add support for reason in WebSocket.close()

> * We need to write a newsfragment for the new feature you've implemented. Could you kindly share the style guide for newsfragments? I couldn't find it in the Contributor's...

Add support for reason in WebSocket.close()

Hi, can I also work on this issue?

Add support for reason in WebSocket.close()

Hi @vytas7, I've done reading the code and found out that there are only limited number of possible Websocket close code. The possibilities that I found are: - 3000+http_status_code: when...

Add support for reason in WebSocket.close()

Hi @vytas7 and @CaselIT, It actually make more sense. What about we do the default mapping thing if the code is among {1000, 1011, 3011}, and generate reason automatically based...

Add support for reason in WebSocket.close()

Also, how will we address the reason in this case? Can we simply write it as "Internal Server Error"? https://github.com/falconry/falcon/blob/47e3e162bf5bd322ec5c2b9a7722e038d635f69f/falcon/asgi/app.py#L972-L980