Wenduo Wang

distcheck failed ``` make[5]: Entering directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal/mca/smsc/accelerator' make distdir-am make[6]: Entering directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal/mca/smsc/accelerator' make[6]: *** No rule to make target 'post_configure.sh', needed by 'distdir-am'. Stop. make[6]: Leaving directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal/mca/smsc/accelerator' make[5]:...

I find jenkins pipeline graph visually misleading. The pipeline steps page shows the failure https://jenkins.open-mpi.org/jenkins/job/open-mpi.pull_request-v2/job/PR-12468/7/flowGraphTable/

@lrbison For the most part, json-parser only provides an API to parse a string. This PR extended that API to support filename. Another reason is that I modeled the JSON...

That's a good idea. I can add an example later.

@bosilca Thank you very much for the review. I have renamed the files as suggested. > What is the benefit to have the OPAL_OBJECT support ? Is this benefit worth...

@juntangc I added an example program in `opal_json.h`. Please take a look.

> If you don't add all the OPAL objectification you only have to free a single object, the initial json object via json_value_free. Simpler and cleaner, no need for extra...

@bosilca Thinking more about OPAL_OBJECT I have a question about inheritance: In this PR I want to hide `json_value` from a 3rd-party library and only expose ``` struct opal_json_t {...

@lrbison @bosilca I added a commit that show the difference if I don't use OPAL_OBJECT. Please take a look and let me know if you like it better.

@jsquyres The PR has been sitting for a while. Could you please let me know if your concerns have been addressed?