Lawrence Mitchell

Results 226 comments of Lawrence Mitchell

> The tests for murmurhash3_x86_32 will only be valid for individual columns If, by valid, you mean "equivalent to calling the murmurhash3_x86_32 function on the row value with the given...

@brandon-b-miller was this one ready to try and get over the line?

Thanks for the report. We recently reorganised the location of the python package (in #1526), but didn't update the documentation. Could you confirm that: ``` $ python -m pip install...

I don't think so. You can make a gmsh mesh that does multiple tags. Or just copy one of those functions and do multiple marking.

Hmmm. Can you try: ```diff diff --git a/python/cudf/cudf/core/column/categorical.py b/python/cudf/cudf/core/column/categorical.py index e3e7303504..fc996e6b6a 100644 --- a/python/cudf/cudf/core/column/categorical.py +++ b/python/cudf/cudf/core/column/categorical.py @@ -515,6 +515,10 @@ class CategoricalColumn(column.ColumnBase): dtype: cudf.core.dtypes.CategoricalDtype _codes: Optional[NumericalColumn] _children: Tuple[NumericalColumn] + _VALID_REDUCTIONS...

> A weak ordering and we don't like ties??? I don't know, I agree that this seems nonsensical on its face. I did some digging, it's a combination of matching...

Oh thanks, I suspect so (pushed that change). Thanks for the sharp eyes!

> Rerunning CI to see if the Dask `2023.2.1` release helped I imagine the problem is that pynvml has been updated to require a v3 version of a function in...

This is WIP until such time as a solution for backwards compat is decided on in nvidia-ml-py (and/or pynvml). So until then we should just keep pynvml at 11.4.1

> Going to double check this, but my understanding is we want PyNVML 11.5 for CUDA 12 support I don't think that is necessary, unless we need features in nvml...