rmm icon indicating copy to clipboard operation
rmm copied to clipboard

[BUG] Cannot build from source with `pip install` way

Open GHGmc2 opened this issue 9 months ago • 3 comments

The docs said: Build, install, and test the rmm python package, in the python folder:

$ python -m pip install -e ./python

But I got error:

Obtaining file:/path/to/rmm/python
ERROR: file:/path/to/rmm/python does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

GHGmc2 avatar Apr 28 '24 11:04 GHGmc2

Thanks for the report. We recently reorganised the location of the python package (in #1526), but didn't update the documentation.

Could you confirm that:

$ python -m pip install -e ./python/rmm

works for you?

wence- avatar Apr 29 '24 08:04 wence-

Thanks for the report. We recently reorganised the location of the python package (in #1526), but didn't update the documentation.

Could you confirm that:

$ python -m pip install -e ./python/rmm

works for you?

Thanks, I believe it's the right path with python -m pip install -e ./python/rmm, but I came across other errors with ngc-pytorch:

Building wheels for collected packages: rmm
  Building editable for rmm (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building editable for rmm (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [52 lines of output]
      WARNING: Use cmake.version instead of cmake.minimum-version with scikit-build-core >= 0.8
      *** scikit-build-core 0.9.3 using CMake 3.29.2 (editable)
      *** Configuring CMake...
      loading initial cache file build/cp310-cp310-linux_x86_64/CMakeInit.txt
      -- RMM: RMM_LOGGING_LEVEL = 'INFO'
      -- CPM: Adding package [email protected] (10.1.1)
      -- Version: 10.1.1
      -- Build type: Release
      -- rapids-cmake [fmt]: applied diff fix_10_1_1_version.diff to fix issue: 'fmt 10.1.1 produces a CMake package with version 10.1.0'
      -- CPM: Adding package [email protected] (v1.12.0)
      -- Build spdlog: 1.12.0
      -- Build type: Release
      -- Generating install
      -- rapids-cmake [spdlog]: applied diff nvcc_constexpr_fix.diff to fix issue: 'Fix constexpr mismatch between spdlog and fmt [https://github.com/gabime/spdlog/issues/2856]'
      -- CPM: Adding package [email protected] (v2.2.0)
      -- rapids-cmake [CCCL]: applied diff bug_fixes.diff to fix issue: 'CCCL installs header-search.cmake files in nondeterministic order and has a typo in checking target creation that leads to duplicates'
      -- rapids-cmake [CCCL]: applied diff hide_kernels.diff to fix issue: 'Mark all cub and thrust kernels with hidden visibility [https://github.com/nvidia/cccl/pulls/443]'
      -- rapids-cmake [CCCL]: applied diff revert_pr_211.diff to fix issue: 'thrust::copy introduced a change in behavior that causes failures with cudaErrorInvalidValue.'
      -- rapids-cmake [CCCL]: applied diff kernel_pointer_hiding.diff to fix issue: 'Hide APIs that accept kernel pointers [https://github.com/NVIDIA/cccl/pull/1395]'
      -- RMM: Enabling static linking of cudart
      -- Configuring done (42.5s)
      -- Generating done (0.2s)
      -- Build files have been written to: /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64
      *** Building project with Ninja...
      [1/20] Transpiling stream.pyx to stream.cxx
      FAILED: rmm/_cuda/stream.cxx /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64/rmm/_cuda/stream.cxx
      cd /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64/rmm/_cuda && /tmp/pip-build-env-z56voy69/overlay/local/bin/cython --cplus -3 --directive binding=True,embedsignature=True,always_allow_keywords=True /lpai/workspace/rmm/python/rmm/rmm/_cuda/stream.pyx --output-file /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64/rmm/_cuda/stream.cxx --depfile && /tmp/pip-build-env-md1c_29s/overlay/local/lib/python3.10/dist-packages/cmake/data/bin/cmake -E cmake_transform_depfile Ninja gccdepfile /lpai/workspace/rmm/python/rmm /lpai/workspace/rmm/python/rmm/rmm/_cuda /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64 /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64/rmm/_cuda /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64/rmm/_cuda/stream.cxx.dep /lpai/workspace/rmm/python/rmm/build/cp310-cp310-linux_x86_64/CMakeFiles/d/556ccaf040c77d55ed2e6fab03f17ecfd6210c9a63792cd31644e703f9b7d074.d
      /bin/bash: line 1: /tmp/pip-build-env-z56voy69/overlay/local/bin/cython: No such file or directory

GHGmc2 avatar Apr 30 '24 01:04 GHGmc2

@GHGmc2 To help others diagnose, can you run the script print_env.sh from this repo and paste the results here? Thanks!

harrism avatar Apr 30 '24 01:04 harrism

@GHGmc2 To help others diagnose, can you run the script print_env.sh from this repo and paste the results here? Thanks!

Attached as below: print_env.log

Besides, I found more link issues in the README like:

For more details, see pyproject.toml

GHGmc2 avatar Apr 30 '24 13:04 GHGmc2