Mathieu Santostefano

Results 64 comments of Mathieu Santostefano

I've rewrite the first draft by inspiring from https://github.com/php-translation/extractor.

@nicolas-grekas It's quite ready for me. Just two questions: - When will we deprecate `PhpExtractor` in favor of `PhpAstExtractor`? - `PhpAstExtractor` is actually registered as service only if nikic/php-parser is...

@DanielBadura > So after a longer discussion with the Lokalise support i got to this version of the LokaliseProvider: > The Diff > > In this diff are 3 changes,...

@DanielBadura could you have a look to failing checks? Otherwise, I think this PR is ready to merge for me

@DanielBadura I'll try to take a look on it this week

Hi @liarco, thanks a lot for this PR. I've some notes to share, > ## Test that I didn't understand, maybe there's an error? > > ``` > // src/Symfony/Component/Translation/Tests/Catalogue/TargetOperationTest.php...

> There is a possible mistake people might run into when they start using the `FallbackLocaleProvider`: > > The `Translator` needs to know when the fallback locales are changed in...

@gndk great work, thank you! Could you please rebase your branch and address the 2 quick comments? Thanks :+1:

@nicolas-grekas is right, we should avoid mutable services, I missed it. :+1: for config option.