Johannes Weiss

Results 188 issues of Johannes Weiss

There are use-cases where the target server can handle more concurrent requests than its `MAX_CONCURRENT_STREAMS` HTTP/2 setting. This is especially often the case behind load balancers which may just pick...

enhancement

For best bulk transfer rates, it'd be great to control the HTTP/2 flow control window. Right now, I think we leave the defaults which are (IIRC) 64k per connection and...

enhancement

`HTTPClient` always has a TLS configuration so we don't need to have `tlsConfiguration` be optional. It should be defaulted to the default config and not `nil`. The code always uses...

We should probably deprecate the `ignoreUncleanSSLShutdown` parameter. AsyncHTTPClient _knows_ when it can and when it cannot ignore an unclean SSL shutdown. Basically if an `.end` was received and we have...

enhancement

`HTTPClient.Request` is a value type (as it should be). Its properties should be mutable (`var`). Otherwise a mere ``` var request = request request.url = newURL ``` becomes a tedious...

`FileDownloadDelegate` calls `pool.start()` on a `NIOThreadPool` that is either provided by the user or by AHC itself through ```swift public init( path: String, pool: NIOThreadPool = NIOThreadPool(numberOfThreads: 1), reportHead: ((HTTPResponseHead)...

bug

Many libraries depend on AHC which is great. The downside is that that means to test these libraries they either need to provide a layer which allows to fake AHC...

enhancement
help wanted

[initial suggestion from @Lukasa] AHC should support a "middleware" concept (ideally once it's a ["3-tier library"](https://github.com/swift-server/async-http-client/issues/392)) where a user can supply some middlewares which do common jobs like following redirects,...

enhancement
help wanted

Immediate questions: - will `didFinishRequest` be called after `didReceiveError`? Yes/No/Maybe - can `didSendRequestHead` be called if either `didFinishRequest` / `didReceiveError` were previously called? - can `didReceiveBodyPart` be called if either...