Weihang Lo comments

Results 766 comments of


                                            Weihang Lo

`cargo install` ignores the `rust-toolchain.toml` or uses the wrong one

Cargo should skip rerun-if-changed paths to files in published crate sources

Your investigation is fantastic! Thank you for the thorough review :) > b) `rerun-if-changed` path points to a directory instead of specific files I believe that's because when Cargo walks...

Cargo should skip rerun-if-changed paths to files in published crate sources

Have yet got time to figure out where the best place is for this change, but I created test for hacking on that. Click to expand the test ```rust #[cargo_test]...

WIP: Add normalized querykind Fixes #1079

Ping @goodSyntax808. Checking in to see if you still got time to sort this out, or if you had any questions. Feel free to continue the discussion here or on...

Ignore `workspace.default-members` when running `cargo install` on root package of a non-virtual workspace

Ping @tedinski. Just checking in to see if you are still interested in working on this, or if you were seeking guidances.

Ignore `workspace.default-members` when running `cargo install` on root package of a non-virtual workspace

@bors r+

Solve problem with panic on some non-ASCII strings in `cargo install`

I'm going to close due to inactivity. We are still interested in improving the error message here. Before going deeper, one needs to figure out how crates.io handles that (mentioned...

Panic with `[patch]` and conflicting equal versions.

Should be fixed by https://github.com/rust-lang/cargo/pull/11770 in 1.70.0. Thanks for the report and the test example!

Report codegen timings for binary crates

Ping @bjorn3 . Just checking in to see if you are still interested in working on this, or if you could have time to check there is no artifact name...

Report codegen timings for binary crates

Thank you for the response. To me, the situation of this PR is different from debuginfo one: The latter would introduce new broken stuff, but the former might break existing...