Weihang Lo
Weihang Lo
IIUC it's hard to determine the package information since cargo-as-rustc does not know about workspace. Also, the emitted suggestions are from primary packages, so we cannot distinguish them by `CARGO_PRIMARY_MANIFEST`....
I feel that going workspace-root way may lead to more problems in the future if we forget to take care of it. OTOH `CARGO_HOME` approach does not cover the local...
@rustbot claim
> Another issue that came up is that some suggestions are for the standard library if you have the rust-src component installed. Those should be protected as well. See [rust-lang/rust#88514...
Just opened as a temporary fix before rustc fix landed.
This is somehow similar to #10094. Cargo does not take into account the new [configurable-env](https://github.com/rust-lang/cargo/issues/9539#) when calculating local fingerprint of `rerun-if-env-changed`. https://github.com/rust-lang/cargo/blob/07e9d46e3d1d33e3342aa578b12887b8991c798b/src/cargo/core/compiler/fingerprint.rs#L1571-L1577 When dealing with this issue, perhaps we should...
If I understand correctly, this shares the same root cause with . Just two different ways to get hurt by the bug.
Copying my comment in : > We should perhaps switch from `std::env::var` to [`Config::get_env`](https://doc.rust-lang.org/nightly/nightly-rustc/cargo/util/config/struct.Config.html#method.get_env) and [`Config::env_config`](https://doc.rust-lang.org/nightly/nightly-rustc/cargo/util/config/struct.Config.html#method.env_config). > > https://github.com/rust-lang/cargo/blob/3a34fca9ee0eeaf63357e89836a72b200553180f/src/cargo/core/compiler/fingerprint/mod.rs#L776-L784 However, there are at least two hard things needing to consider....
This is definitely a duplicate of . Since that one was closed, I'll keep this open. --- From : > I believe this is correct behavior on behalf of Cargo...
In #13171 we have an idea that a new subcommand like `cargo debug` generates remap rules for debuggers, so that debug info never contains a fixed absolute path and instead...