Weihang Lo

Results 766 comments of Weihang Lo

Here are the three commits: * https://github.com/aptos-labs/aptos-core/tree/aptos-cli-v3.0.1/ecosystem/indexer-grpc/indexer-grpc-parser -> `6fdc6f31fcc494d4ba77ca3bdc8c9eb6b3fc1acb` * https://github.com/aptos-labs/aptos-core/blob/aptos-cli-v3.0.1/crates/aptos/Cargo.toml#L83 -> `d44b2d209f57872ac593299c34751a5531b51352` * https://github.com/aptos-labs/aptos-core/blob/aptos-cli-v3.0.1/Cargo.toml#L458 -> `4801acae7aea30d7e96bbfbe5ec5b04056dfa4cf` I haven't got time creating a minimal reproducer with a similar layout though....

Nice finding! > Another option is cargo could assume something that is 40 hexadecimal characters is an commit hash, and not a tag, and use the single commit refspec. I'm...

@mqudsi Pretty not sure. In the affected project using some orphan commits. Perhaps fetching orphan commits needs more requests so easier to hit rate limit because they might be gc'd?...

Under `~/.cargo/git`, check if the git clone contains a `-shallow` suffix. ```console ~/.cargo/git $ tree -L 2 ./ ├── checkouts/ │ └── empty-library-0161899a0cd3bb43-shallow/ └── db/ └── empty-library-0161899a0cd3bb43-shallow/ ``` As of...

`-Zgitoxide` was first developed. The shallow clone support in libgit2 came out after and then we decided to split into `-Zgit` and `-Zgitoxide`. The former controls Git related unstable features...

Sparse checkout and partial clone have been discussed in . It is possible that Cargo ditch or adopt anything for `-Zgit` since it is still an experimental unstable feature. See...

For myself, I would wait for FCP in and see if we can avoid adding an extra flag. We can perhaps think ahead how the layout should be like with...

Thanks for the report! > I noticed that all of the crates were being compiled with cranelift and not LLVM, How did you verify this? From the verbose output of...

I am not too familiar with this area. Let's seek helps from cranelift codegen maintainers. @bjorn3, what is the risk of mix use of different codegen backends across different crates?...

Have we documented this behavior in The Cargo Book? If not, I would like to propose this as a documentation issue. https://github.com/rust-lang/cargo/blob/363a2d11320faf531f6aacd1ea067c6bc08343b9/src/bin/cargo/main.rs#L247-L270