Weidong Xu

Results 125 comments of Weidong Xu

A comment on `status` property in the response of the PUT, for "PUT to resource with additional long-running processing". https://github.com/microsoft/api-guidelines/pull/517#discussion_r1554827307 I don't think we should add the `status` to resource...

I am OK with the API. But all those error in "Breaking Change(Cross-Version)" need to be approved separately. My recommendation is go with the typespec.

The LintDiff CI seems not working as expected. I've opened an issue for this https://github.com/Azure/azure-sdk-tools/issues/8165

Ignore the LintDiff, as error is about `/sentShare` which is not in this tsp/swagger. https://github.com/Azure/azure-sdk-tools/issues/8165#issuecomment-2095259470

> > There seems to be major changes to the new api-version. > > Make sure you had scheduled an API review meeting. > > There are no breaking changes...

if a test, change to draft

@lmazuel Let me know if this change is acceptable. Personally I feel we should always provide a clean model for response body, as almost all SDK need to generate a...

Alternatively, if we don't want this PR, emitter can add this "remove non-payload property" logic (for all SDKs). https://github.com/Azure/cadl-azure/blob/main/packages/cadl-autorest/src/openapi.ts#L1365-L1367

about 44 of ModelValidation is from PR https://github.com/Azure/azure-rest-api-specs/pull/21015#issuecomment-1269122734 other appears to be api-version in example is 2021-03-01

pending PR to this branch - https://github.com/Azure/azure-rest-api-specs/pull/21984 - https://github.com/Azure/azure-rest-api-specs/pull/22159 - https://github.com/Azure/azure-rest-api-specs/pull/22341