azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
[Defender (RiskIQ) - EASM] Api version 2024-03-01-preview
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
- Link to API Spec engagement record issue:
Is this review for (select one):
- [ ] a private preview
- [x] a public preview
- [ ] GA release
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
- Design Document:
- Previous API Spec Doc: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/riskiq/data-plane/Microsoft.Easm/preview/2023-03-01-preview/easm.json
- Updated paths:
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
- 💬 Teams Channel
Click here for links to tools, specs, guidelines & other good stuff
Tooling
- Open API validation tools were run on this PR. Go here to see how to fix errors
- Spectral Linting
- Open API Hub
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.fix https://github.com/Azure/azure-rest-api-specs/issues/28855
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| easm.json | 2024-03-01-preview(d8c7748) | 2023-03-01-preview(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 13 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| 2024-03-01-preview | 2024-03-01-preview(d8c7748) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L240 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L250 |
|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L351 |
|
| :warning: PaginationResponse | value property in pageable response should be requiredLocation: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L379 |
|
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L407 |
|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L454 |
|
| :warning: OperationId | OperationId for get method on a collection should contain 'List' Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L455 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L506 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L933 |
|
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1110 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1827 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1873 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L7105 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| :warning: SecurityDefinitionDescription | Security definition should have a description. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L43 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L204 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L600 |
| :warning: PutRequestResponseScheme | A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'DataConnections_CreateOrReplaceDataConnection' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L634 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L644 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L696 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L837 |
| :warning: PutRequestResponseScheme | A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'DiscoveryGroups_CreateOrReplaceDiscoGroup' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L871 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L881 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L976 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1028 |
| :warning: PaginationResponse | value property in pageable response should be requiredLocation: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1035 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1265 |
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1301 |
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1434 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1542 |
| :warning: PutRequestResponseScheme | A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'SavedFilters_CreateOrReplaceSavedFilter' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1576 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1586 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1638 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1735 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1781 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1932 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L2315 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L2382 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L2400 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L2496 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L2589 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L2807 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L2975 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L3131 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed in generating from f77b42bf522e0e9f05e0a009c4efd434e9711f18. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn specification/riskiq/data-plane/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131 cmderr [Invoke-GenerateAndBuildV2.ps1] Line | cmderr [Invoke-GenerateAndBuildV2.ps1] 131 | GeneratePackage ` cmderr [Invoke-GenerateAndBuildV2.ps1] | ~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] | Failed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807 cmderr [Invoke-GenerateAndBuildV2.ps1] Line | cmderr [Invoke-GenerateAndBuildV2.ps1] 807 | … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s … cmderr [Invoke-GenerateAndBuildV2.ps1] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] | Cannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] | it does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131 cmderr [Invoke-GenerateAndBuildV2.ps1] Line | cmderr [Invoke-GenerateAndBuildV2.ps1] 131 | GeneratePackage ` cmderr [Invoke-GenerateAndBuildV2.ps1] | ~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] | Failed to generate sdk artifact
❌Azure.Analytics.Defender.Easm [Preview SDK Changes]info [Changelog]
️❌ azure-sdk-for-js failed [Detail]
❌Code Generator Failed in generating from f77b42bf522e0e9f05e0a009c4efd434e9711f18. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read warn specification/riskiq/data-plane/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json cmderr [automation_generate.sh] [ERROR] Command failed: pwsh ./eng/common/scripts/TypeSpec-Project-Process.ps1 /mnt/vss/_work/1/s/azure-rest-api-specs/specification/riskiq/Easm f77b42bf522e0e9f05e0a009c4efd434e9711f18 https://github.com/Azure/azure-rest-api-specs cmderr [automation_generate.sh] [ERROR] Command failed: pwsh ./eng/common/scripts/TypeSpec-Project-Process.ps1 /mnt/vss/_work/1/s/azure-rest-api-specs/specification/riskiq/Easm f77b42bf522e0e9f05e0a009c4efd434e9711f18 https://github.com/Azure/azure-rest-api-specs error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh warn Skip package processing as generation is failed
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning in generating from f77b42bf522e0e9f05e0a009c4efd434e9711f18. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json warn specification/riskiq/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] error: import-not-found - Couldn't resolve import "@azure-tools/typespec-azure-rulesets" @ unknown cmderr [generate.py] error: unknown-rule-set - Rule set "data-plane" is not found in library "@azure-tools/typespec-azure-rulesets" @ unknown
️✔️azure-analytics-defender-easm [Preview SDK Changes]- pom.xml
- azure-analytics-defender-easm-1.0.0-beta.2-sources.jar
- azure-analytics-defender-easm-1.0.0-beta.2.jar
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Java | azure-analytics-defender-easm | https://apiview.dev/Assemblies/Review/f3d03dbdd78d43bc84b0828a5c4e6f07?revisionId=0aaba8499aa84c8dab12d7a19e948187 |
| Swagger | Microsoft.Easm | https://apiview.dev/Assemblies/Review/f342fa03d74e4fd59892676d74db996e?revisionId=6e70ed06c0e042f3b9b6e17fa6ac7cdb |
| TypeSpec | Easm | https://apiview.dev/Assemblies/Review/c2e5d55db3fa4ae9a05ae50da30092de?revisionId=e3bf0213d1a748d0b3085eba9e4c8dae |
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
Swagger Generation Artifacts
️🔄ApiDocPreview inProgress [Detail]
️⌛ azure-sdk-for-net-track2 pending [Detail]
️⌛ azure-sdk-for-js pending [Detail]
️⌛ azure-sdk-for-java pending [Detail]
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail]
| Compared specs (v0.10.7) | new version | base version |
|---|---|---|
| easm.json | 2023-03-01-preview(3cc0364) | 2023-03-01-preview(main) |
| Rule | Message |
|---|---|
|
The new version is adding enum value(s) '2024-03-01-preview' from the old version. New: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L5575:5 Old: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L5575:5 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
| Compared specs (v0.10.7) | new version | base version |
|---|---|---|
| easm.json | 2024-03-01-preview(3cc0364) | 2023-03-01-preview(main) |
️🔄CredScan inProgress [Detail]
️⚠️LintDiff: 13 Warnings warning [Detail]
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| 2023-03-01-preview | 2023-03-01-preview(3cc0364) | 2023-03-01-preview(main) |
| 2024-03-01-preview | 2024-03-01-preview(3cc0364) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L250 |
|
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L286 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L296 |
|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L395 |
|
| :warning: PaginationResponse | value property in pageable response should be requiredLocation: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L427 |
|
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L455 |
|
| :warning: ListInOperationName | Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L500 |
|
| :warning: OperationId | OperationId for get method on a collection should contain 'List' Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L501 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L552 |
|
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1115 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1832 |
|
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L1878 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2024-03-01-preview/easm.json#L6979 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| :warning: SecurityDefinitionDescription | Security definition should have a description. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L43 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L192 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L286 |
| :warning: PutRequestResponseScheme | A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'DataConnections_CreateOrReplaceDataConnection' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L320 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L330 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L382 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L523 |
| :warning: PutRequestResponseScheme | A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'DiscoveryGroups_CreateOrReplaceDiscoGroup' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L557 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L567 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L621 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L673 |
| :warning: PaginationResponse | value property in pageable response should be requiredLocation: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L680 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L816 |
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L852 |
| :warning: PaginationResponse | Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L938 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1046 |
| :warning: PutRequestResponseScheme | A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'SavedFilters_CreateOrReplaceSavedFilter' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1080 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1090 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1142 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1239 |
| :warning: PathParameterSchema | Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1285 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1344 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1630 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1661 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1679 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1775 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L1847 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L2048 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L2148 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Easm/preview/2023-03-01-preview/easm.json#L2285 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️❌TypeSpecAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⌛PoliCheck pending [Detail]
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
.Net CI pipeline failed because the model name broke the .NET SDK Analyzer rule AZC0030 (see following). You may need to customize the model's name for csharp or ask approval from arch board and then suppress it.
error AZC0030: Model name 'ObservationResponse' ends with 'Response'. Suggest to rename it to 'ObservationResult' or any other appropriate name. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/easm/Azure.Analytics.Defender.Easm/src/Azure.Analytics.Defender.Easm.csproj::TargetFramework=netstandard2.0]
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
I checked this pr locally and we could build it but we have an issue when generating apiView (tracked here). Will take a look when back from holiday.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
There seems to be major changes to the new api-version.
Make sure you had scheduled an API review meeting.
There are no breaking changes so this PR wasn't labeled that we need a review. We are only adding new endpoints, not making breaking changes. Do we still need a review? If so, why?
There seems to be major changes to the new api-version. Make sure you had scheduled an API review meeting.
There are no breaking changes so this PR wasn't labeled that we need a review. We are only adding new endpoints, not making breaking changes. Do we still need a review? If so, why?
https://eng.ms/docs/products/azure-developer-experience/design/api-review
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.