Weidong Xu

Results 125 comments of Weidong Xu

@TimLovellSmith They would need to get approval from breaking changes review, as bot comment here https://github.com/Azure/azure-rest-api-specs/pull/21020#issuecomment-1269887661 Generally, Jeffrey would go review and check if they can do that. If this...

Ignore BreakingChange and ModelValidation BreakingChanges compare to 2022-09-01-preview in main and figure out several new APIs. Data-plane usually have different jsons. ModelValidation on "LRO_RESPONSE_HEADER" only apply to ARM.

Guide to ask for approval of the new namespace for SDK https://azure.github.io/azure-sdk/policies_reviewprocess.html for instance, review for appcomplianceautomation: https://github.com/Azure/azure-sdk/issues/4969

Appears that you are adding missing properties that should be documented in swagger in this api-version. But I will still need an approval from breaking changes for this. Let me...

Is the question for LRO case or non-LRO case (latest data-plane guideline discourages LRO Patch, but LRO Patch is common in ARM)?

1. we can wait a while for response from EngSys. 2. then we can see if we use a static hostname, or a default one if Java call does not...

@XiaofeiCao Do you have change to check?

Should we double check the place we call `Inet4Address.getLocalHost()` and check whether we can safely assume user machine can get its IP address? If not, when machine cannot get IP...

`com.azure.resourcemanager:azure-resourcemanager-test:jar` is not published to maven, as it is only used for testing. I am not sure why the CI need `dependency:copy-dependencies`, but if you need it, exclude the package...