azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Separate aks and fleet in containerservice

Open FumingZhang opened this issue 2 years ago • 10 comments

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [x] Other, reformat folder structure under namespace Microsoft.Containerservice to separate aks and fleet into two parts with separate Autorest configs.
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. No new service/feature.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. ASAP.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

FumingZhang avatar Oct 25 '22 05:10 FumingZhang

Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️🔄LintDiff inProgress [Detail]
    ️❌Avocado: 108 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2018-08-01-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2018-08-01-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2018-09-30-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2018-09-30-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2019-09-30/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2019-09-30
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2019-10-27-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2019-10-27-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2021-11-01-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2021-11-01-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-01-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-01-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-02-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-02-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-03-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-03-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-04-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-04-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-05-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-05-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-06-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-06-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-07-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-07-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-08-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-08-02-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-08-03-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-08-03-preview
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: Microsoft.ContainerService/preview/2022-09-02-preview/examples
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: resource-manager/Microsoft.ContainerService/preview/2022-09-02-preview
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️🔄ModelValidation inProgress [Detail]
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️❌SpellCheck: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Unknown word (Ochestrator), please fix the error or add words to ./custom-words.txt
    path: aks/stable/2016-03-30/containerService.json#L269:38
    HowToFix Unknown word (Ochestrator), please fix the error or add words to ./custom-words.txt
    path: aks/stable/2016-09-30/containerService.json#L305:38
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/containerservice/armcontainerservice - 3.0.0
    +	Const `ContainerServiceStorageProfileTypesManagedDisks` has been removed
    +	Const `ContainerServiceStorageProfileTypesStorageAccount` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA10` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA11` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA1V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA1` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA2MV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA2V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA4MV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA4V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA4` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA5` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA6` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA7` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA8MV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA8V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA8` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardA9` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardB2Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardB2S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardB4Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardB8Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD11V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD11V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD11` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD12V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD12V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD12` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD13V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD13V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD13` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD14V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD14V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD14` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD15V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD16SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD16V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD1V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD1` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD2SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD2V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD2V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD2V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD32SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD32V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD3V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD3V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD4SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD4V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD4V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD4V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD4` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD5V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD5V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD64SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD64V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD8SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardD8V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS11V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS11V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS11` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS12V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS12V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS12` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS132V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS134V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS13V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS13V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS13` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS144V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS148V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS14V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS14V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS14` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS15V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS1V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS1` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS2V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS2V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS3V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS3V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS4V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS4V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS4` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS5V2Promo` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardDS5V2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE16SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE16V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE2SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE2V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE3216SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE328SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE32SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE32V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE4SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE4V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE6416SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE6432SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE64SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE64V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE8SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardE8V3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF16SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF16S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF16` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF1S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF1` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF2SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF2S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF32SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF4SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF4S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF4` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF64SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF72SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF8SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF8S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardF8` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardG1` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardG2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardG3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardG4` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardG5` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS1` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS44` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS48` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS4` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS516` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS58` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardGS5` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardH16M` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardH16Mr` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardH16R` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardH16` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardH8M` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardH8` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardL16S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardL32S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardL4S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardL8S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM12832Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM12864Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM128Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM128S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM6416Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM6432Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM64Ms` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardM64S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC12SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC12SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC12` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC24R` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC24RsV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC24RsV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC24SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC24SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC24` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC6SV2` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC6SV3` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNC6` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardND12S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardND24Rs` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardND24S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardND6S` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNV12` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNV24` has been removed
    +	Const `ContainerServiceVMSizeTypesStandardNV6` has been removed
    +	Const `CountFive` has been removed
    +	Const `CountOne` has been removed
    +	Const `CountThree` has been removed
    +	Function `PossibleContainerServiceStorageProfileTypesValues` has been removed
    +	Function `PossibleContainerServiceVMSizeTypesValues` has been removed
    +	Function `PossibleCountValues` has been removed
    +	Struct `CloudErrorBody` has been removed
    +	Struct `CloudError` has been removed
    +	Struct `DiagnosticsProfile` has been removed
    +	Struct `MasterProfile` has been removed
    +	Struct `Resource` has been removed
    +	Struct `SubResource` has been removed
    +	Struct `TrackedResource` has been removed
    +	Struct `VMDiagnostics` has been removed
    +	Type alias `ContainerServiceStorageProfileTypes` has been removed
    +	Type alias `ContainerServiceVMSizeTypes` has been removed
    +	Type alias `Count` has been removed


    azure-sdk-for-python-track2 - track2_azure-mgmt-containerservice - 20.5.0
    +	Removed operation group FleetMembersOperations
    +	Removed operation group FleetsOperations

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from d055ff8793d3ecb3b95b05255daa4046d3bc3614. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-containerservice [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model AgentPoolNetworkProfile has a new parameter allowed_host_ports
      info	[Changelog]   - Model AgentPoolNetworkProfile has a new parameter application_security_groups
      info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter ebpf_dataplane
      info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter custom_ca_trust_certificates
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Removed operation group FleetMembersOperations
      info	[Changelog]   - Removed operation group FleetsOperations
    • ️✔️track2_azure-mgmt-containerservicefleet [View full logs]  [Preview SDK Changes]
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from d055ff8793d3ecb3b95b05255daa4046d3bc3614. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from d055ff8793d3ecb3b95b05255daa4046d3bc3614. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/containerservice/armcontainerservice [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - Const `CountFive` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardA8V2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardNC6SV3` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardA1V2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardDS11V2Promo` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardD4` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardA4MV2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardNC12SV3` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardDS148V2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardNC24R` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardL32S` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardDS15V2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardF1` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardF8` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardNC6` has been removed
      info	[Changelog] - Const `ContainerServiceStorageProfileTypesManagedDisks` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardA3` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardE8V3` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardD12` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardE16V3` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardND6S` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardD4V3` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardNV6` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardND24S` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardF4` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardF16SV2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardDS14V2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardGS516` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardD3` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardDS5V2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardDS2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardDS12V2` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardD11V2Promo` has been removed
      info	[Changelog] - Const `ContainerServiceVMSizeTypesStandardD14` has been removed
      info	[Changelog] - Type alias `Count` has been removed
      info	[Changelog] - Type alias `ContainerServiceStorageProfileTypes` has been removed
      info	[Changelog] - Type alias `ContainerServiceVMSizeTypes` has been removed
      info	[Changelog] - Function `PossibleContainerServiceVMSizeTypesValues` has been removed
      info	[Changelog] - Function `PossibleCountValues` has been removed
      info	[Changelog] - Function `PossibleContainerServiceStorageProfileTypesValues` has been removed
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog] - Struct `CloudErrorBody` has been removed
      info	[Changelog] - Struct `DiagnosticsProfile` has been removed
      info	[Changelog] - Struct `MasterProfile` has been removed
      info	[Changelog] - Struct `Resource` has been removed
      info	[Changelog] - Struct `SubResource` has been removed
      info	[Changelog] - Struct `TrackedResource` has been removed
      info	[Changelog] - Struct `VMDiagnostics` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*ManagedClustersClient.BeginRotateServiceAccountSigningKeys(context.Context, string, string, *ManagedClustersClientBeginRotateServiceAccountSigningKeysOptions) (*runtime.Poller[ManagedClustersClientRotateServiceAccountSigningKeysResponse], error)`
      info	[Changelog] - New struct `ManagedClusterOIDCIssuerProfile`
      info	[Changelog] - New struct `ManagedClusterStorageProfileBlobCSIDriver`
      info	[Changelog] - New struct `ManagedClustersClientBeginRotateServiceAccountSigningKeysOptions`
      info	[Changelog] - New struct `ManagedClustersClientRotateServiceAccountSigningKeysResponse`
      info	[Changelog] - New field `OidcIssuerProfile` in struct `ManagedClusterProperties`
      info	[Changelog] - New field `BlobCSIDriver` in struct `ManagedClusterStorageProfile`
      info	[Changelog]
      info	[Changelog] Total 201 breaking change(s), 11 additive change(s).
    • ️✔️sdk/resourcemanager/containerservice/armcontainerservicefleet [View full logs]  [Preview SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from d055ff8793d3ecb3b95b05255daa4046d3bc3614. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerservice [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation ManagedClusters.beginRotateServiceAccountSigningKeys
      info	[Changelog]   - Added operation ManagedClusters.beginRotateServiceAccountSigningKeysAndWait
      info	[Changelog]   - Added Interface ManagedClusterOidcIssuerProfile
      info	[Changelog]   - Added Interface ManagedClustersRotateServiceAccountSigningKeysHeaders
      info	[Changelog]   - Added Interface ManagedClustersRotateServiceAccountSigningKeysOptionalParams
      info	[Changelog]   - Added Interface ManagedClusterStorageProfileBlobCSIDriver
      info	[Changelog]   - Added Type Alias ManagedClustersRotateServiceAccountSigningKeysResponse
      info	[Changelog]   - Interface ManagedCluster has a new optional parameter oidcIssuerProfile
      info	[Changelog]   - Interface ManagedClusterStorageProfile has a new optional parameter blobCSIDriver
    • ️✔️@azure/arm-containerservicefleet [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from d055ff8793d3ecb3b95b05255daa4046d3bc3614. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ResourceIdentityType' and different values: SystemAssigned,UserAssigned,None vs. SystemAssigned
      cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
      cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
      cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
      cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
      cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
      cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      cmderr	[Autorest]    at NewPlugin.<Process>d15.MoveNext()
      cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
      cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
      cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip command for failed context: autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerservice/resource-manager/Microsoft.ContainerService/fleet/readme.md
      warn	Skip package processing as generation is failed
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from d055ff8793d3ecb3b95b05255daa4046d3bc3614. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      cannot force update branch 'sdkAuto/21259/containerservice' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/21259/containerservice' as it is the current HEAD of the repository.
    • ️✔️containerservice [View full logs
    • ️✔️containerservice [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/21259/containerservice' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		containerservice
      error		containerservice
    ️❌ azure-powershell failed [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/containerservice/armcontainerservice https://apiview.dev/Assemblies/Review/a51b54e50f9248828f00ecc361dc3837
    Go sdk/resourcemanager/containerservice/armcontainerservicefleet https://apiview.dev/Assemblies/Review/ae28a4c2f37e48dabd43b0d3c3e445fa
    JavaScript @azure/arm-containerservice https://apiview.dev/Assemblies/Review/b9b32dff0db5440792d3e1d6986eaefc
    JavaScript @azure/arm-containerservicefleet https://apiview.dev/Assemblies/Review/d820e0907f384de1b1a92c1a0238def6
    Python track2_azure-mgmt-containerservice Create ApiView timeout. Package is too large and we cannot create ApiView for it.
    Python track2_azure-mgmt-containerservicefleet https://apiview.dev/Assemblies/Review/cdcf4fb10ad44851a862a1741806d12f

    In this PR, the 2 services (aks, fleet) under namespace Microsoft.ContainerService are split into 2 separate subfolders. Add new Autorest configuration files (readmes) for fleet to generate independent SDKs. No changes to the content of existing swagger files.

    FumingZhang avatar Oct 25 '22 08:10 FumingZhang

    For the 12 failed checks,

    • Breaking Change(Cross-Version), list items are all as expected, they were reviewed when creating the swagger for these API versions. Also no change to the content of existing swagger files in this PR.
    • PR Summary, it failed due to no such file or directory, open 'specification/containerservice/resource-manager/readme.md', which is exactly what this PR changed (the readmes are moved to subfolders), so is this error tolerable?
    • SDK azure-powershell, similar error as occurred in previous swagger releases (e.g., add API version 2022-09-01). I did not (and did not before) configure powershell to generate corresponding products for each of the two services.
    • SDK azure-resource-manager-schemas, error msg is cannot force update branch 'sdkAuto/21259/containerservice' as it is the current HEAD of the repository. seems like a temporary error to me
    • SDK azure-sdk-for-net , similar error occurred in previous swagger releases (e.g., add API 2022-09-01). I suppose this check is for track 1 SDK, and .NET has released track 2 SDK for containerservice.
    • Swagger Avocado, all 100+ items are about MISSING_README. Do I put the readmes in the wrong folder? But it seems SDK could be generated successfully.
    • Swagger BreakingChange, 3637 errors, look like caused by moving the swagger files, since no change to the content of existing swagger files in this PR.
    • Swagger LintDiff, 3621 errors, due to the change of the file path, the places in the swagger files corresponding to the old API versions that do not conform to the current specification are scanned out. No change to the content of existing swagger files in this PR.
    • Swagger ModelValidation, 1556 errors, similar to the previous two checks. No change to the content of existing swagger files in this PR.
    • Swagger SDK Breaking Change Tracking, unused model definitions are removed in go SDK, which is somehow expected (also happened in add API version 2022-09-01). Another issue is fleet related operations are removed from Python SDK azure-mgmt-containerservice, which is also expected, since they are moving to a new SDK named azure-mgmt-containerservicefleet.
    • Swagger SpellCheck, the word Ochestrator (used in 2016-03-30 API) needs to be added to custom_words.txt.
    • ~[Staging] Swagger LintDiff, 6814 errors, there is something wrong with the check itself, some normal annotations are also marked as errors (e.g., 'arm-id' is not considered as a valid format).

    FumingZhang avatar Oct 25 '22 10:10 FumingZhang

    In this PR, the 2 services (aks, fleet) under namespace Microsoft.ContainerService are split into 2 separate subfolders. Add new Autorest configuration files (readmes) for fleet to generate independent SDKs. No changes to the content of existing swagger files.

    As seems SDK has been split into 2 packages. + different SDK lang owner to confirm: @weidongxu-microsoft @msyyc @qiaozha @tadelesh @fengzhou-msft to confirm and review readme

    akning-ms avatar Oct 26 '22 08:10 akning-ms

    Guide to ask for approval of the new namespace for SDK https://azure.github.io/azure-sdk/policies_reviewprocess.html

    for instance, review for appcomplianceautomation: https://github.com/Azure/azure-sdk/issues/4969

    weidongxu-microsoft avatar Oct 26 '22 10:10 weidongxu-microsoft

    Hi, @FumingZhang. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 27 '22 16:11 ghost

    Hi, @FumingZhang. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Dec 18 '22 16:12 ghost

    Hi, @FumingZhang. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Jan 02 '23 05:01 ghost