webwarrior-ws

Results 56 comments of webwarrior-ws

@knocte Rebased on top of latest `master` branch.

I've looked closely at `SuggestedFix` type. And it has 2 fields that are supposed to serve the same purpose: ```fsharp /// Text to be replaced. FromText ``` and ```fsharp ///...

> Please compare to master branch, which I guess gives a bit of separation between the "Amount:" label and the "Not enough funds" label. Added padding between labels in Maui/Gtk

> @webwarrior-ws you can now rebase this PR, and we should have green CI statuses all over the place? BTW please remove the WIP thing from the DOTNET_ROLL_FORWARD commit because...

Should I move commit that uploads Maui snap to the end so we upload only once?

> * snap/local/snapcraft_maui.yaml: $CRAFT??? Is this correct? Yes, in version 7 prefix changed from `SNAPCRAFT_` to `CRAFT_`, see https://snapcraft.io/docs/parts-lifecycle#heading--parts-directories

> * `CI,scripts,snap,Frontend.Maui: use .NET 8`: missing the why IIRC navigation bar bug was what got us considering switch to .NET8. But that wasn't the only reason? .NET6 is nearing...

Superseded by #299

Indeed `response.Result` is `null` in our case, although `returnDefaultIfNull` does nothing in this case since default of `Nethereum.Hex.HexTypes.HexBigInteger` is null also. Enabling debug output showed that response json was: ```...

So I think this should be handled on geewallet side. But I don't know which exception type to use here to signal invalid response from serever.