MAUI: first steps

[webwarrior-ws]

Supersedes #274

[knocte]

@webwarrior-ws let's fix the style of the welcomePage, in Linux it looks like this:

[knocte]

let's fix the style of the welcomePage, in Linux it looks like this:

Looking at same screenshot above, another issue: window title is not the same as geewallet (should be "geewallet", not "GWallet.Frontend.Maui"

[knocte]

I found another toolbar-related bug: after sending a payment, and clicking "ok" on the modal dialog that tells me that the transaccion was succesful, the wallet goes back to the ReceivePage but doesn't show a back button:

[knocte]

With regards to style, the buttons at the bottom of the pages are always too close to the other widgets, while there should be some padding:

• Next button:

• Finish button:

• Both "Send" and "Cancel" buttons:

I guess what happens is that XamarinForms has some sort of default padding for the stacklayout elements or something, because I see some proper separation in geewallet master branch (even between the textboxes). Example:

[knocte]

@webwarrior-ws nit: please fix all commit messages to use the word "scripts", not "Scripts", because this word is matching a folder name in the repo, and it should match its case to avoid any confusions.

[knocte]

Nit I found in GTK:

Please compare to master branch, which I guess gives a bit of separation between the "Amount:" label and the "Not enough funds" label.

[webwarrior-ws]

Please compare to master branch, which I guess gives a bit of separation between the "Amount:" label and the "Not enough funds" label.

Added padding between labels in Maui/Gtk

[knocte]

@webwarrior-ws you can now rebase this PR, and we should have green CI statuses all over the place? BTW please remove the WIP thing from the DOTNET_ROLL_FORWARD commit because it's not wip anymore.

[webwarrior-ws]

@webwarrior-ws you can now rebase this PR, and we should have green CI statuses all over the place? BTW please remove the WIP thing from the DOTNET_ROLL_FORWARD commit because it's not wip anymore.

Only DOTNET_ROLL_FORWARD commit will be green, unless I move it earlier or squash with "use .NET8" commit

[knocte]

Only DOTNET_ROLL_FORWARD commit will be green, unless I move it earlier or squash with "use .NET8" commit

Let's squash it then, but then you have to explain it properly in the .NET8's commit msg.

[webwarrior-ws]

Should I move commit that uploads Maui snap to the end so we upload only once?

[knocte]

Yes

[knocte]

Hopefully the last review before merging:

Files:

• snap/local/snapcraft_maui.yaml: $CRAFT??? Is this correct?
• src/GWallet.Frontend.XF/BalancesPage.xaml: is the comment saying that it’s a workaround for GTK? If yes, don’t forget the word ‘workaround’

Commits:

• CI,scripts,snap,Frontend.Maui: use .NET 8: missing the why
• Dependencies: change from CrossMaui to Mali: there’s no subscope called “Dependencies” (other commits that change deps are not scoped like this).
• Dependencies: update Maui dependency: same here, there’s no subscope called “Dependencies” (other commits that change deps are not scoped like this).
• WIP: use dotnet-runtime-7.0 in MAUI snap: why is this still WIP?
• Snap: use dotnet runtime from packages: in this case, the sub scope matches with a folder of the repo, however, case sensitivity is not respected, please fix.
• CI,Scripts,Frontend.Maui: build MAUI snap: same here, respect case in sub scope please.
• Frontend.Maui: update Maui dependency: let’s call it submodule, not dependency, to make it crystal clear
• Frontend.Maui: fix spacing after "Amount" label: you are not explaining in commit msg body what was wrong with the spacing
• Frontend(XF,Maui): fix in WelcomePage (datepicker): you are not explaining in commit msg body how the layout was "broken"
• Frontend.Maui: Color.Default equivalent for maui: nit: proper casing for Maui: either Maui or MAUI, but not all lowercase
• Frontend.Maui: use XF xaml files for building proj: nit: proper casing for XAML (it’s an acronym)
• Frontend.Maui: workaround for build fail in VS22: check the diff, indentation is not correct
• Frontend.Maui: make possible debugging in Linux: should be “make Linux debugging possible”
• WIP: show navigation bar on Android: why is this still WIP?
• scripts,CI: determine & build frontend in scripts: this commit breaks CI, and as far as I understand, the commit that fixes this failure is not the next, but the one titled “CI,scripts,snap,Frontend.Maui: use .NET 8”, so I guess they should be moved to be next to each other, otherwise there is a bunch of commits in between that have red CI for no reason.

[webwarrior-ws]

• snap/local/snapcraft_maui.yaml: $CRAFT??? Is this correct?

Yes, in version 7 prefix changed from SNAPCRAFT_ to CRAFT_, see https://snapcraft.io/docs/parts-lifecycle#heading--parts-directories

[webwarrior-ws]

• CI,scripts,snap,Frontend.Maui: use .NET 8: missing the why

IIRC navigation bar bug was what got us considering switch to .NET8. But that wasn't the only reason? .NET6 is nearing end of support anyways.

[knocte]

IIRC navigation bar bug was what got us considering switch to .NET8. But that wasn't the only reason? .NET6 is nearing end of support anyways.

The latter is just a secondary reason (in importance); mention both but emphasize on the navigation problem.

[webwarrior-ws]

Superseded by #299