Lars Kappert comments

Results 640 comments of


                                            Lars Kappert

💡 Knip should throw on an invalid config

:rocket: _This issue has been resolved in v5.48.0. See [Release 5.48.0](https://github.com/webpro-nl/knip/releases/tag/5.48.0) for release notes._ _Using Knip in a commercial project? Please consider [becoming a sponsor](https://knip.dev/sponsors)._

Git-ignore rules inside a project should not match parts of the absolute path outside the project

Thanks for the bug report. I wonder how it's possible the `**/build` pattern matching files outside the pattern influences the results? Any chance a small explanation or even reproduction could...

Git-ignore rules inside a project should not match parts of the absolute path outside the project

Thanks, that helped a lot. I think I found the issue, it seems to originate here in fast-glob: https://github.com/mrmlnc/fast-glob/issues/441 Need to figure out whether it can/will be fixed downstream, or...

Git-ignore rules inside a project should not match parts of the absolute path outside the project

Thanks, I'd prefer fixes and test coverage in the downstream lib, let's await that first: https://github.com/mrmlnc/fast-glob/pull/445

Git-ignore rules inside a project should not match parts of the absolute path outside the project

It happened: https://github.com/mrmlnc/fast-glob/releases/tag/3.3.3

Git-ignore rules inside a project should not match parts of the absolute path outside the project

This has been fixed since [v5.42.0](https://github.com/webpro-nl/knip/releases/tag/5.42.0).

💡 Respect `pageExtensions` option in Next.js config

Knip _could_ run `next.config.ts` (it does this for many plugins). Feel free to take a stab at it, there are a few plugins that do something similar already: - https://github.com/webpro-nl/knip/blob/main/packages/knip/src/plugins/nuxt/index.ts...

💡 Respect `pageExtensions` option in Next.js config

Why not override `next.entry` in your Knip config instead of patching the package, if I may ask?

💡 Respect `pageExtensions` option in Next.js config

Great! And indeed the issue is still relevant, but it would require some work and testing as it requires to actually load (not just statically parse) `next.config.ts`, which might come...

💡 Respect `pageExtensions` option in Next.js config

This is resolved by merging #1005.