webbjj
webbjj
Hi Long Wang This is awesome work. Apologies for not chiming in sooner. Incorporating galpy potentials should really allow for petar to be used for a wide range of problems....
> Thanks for the suggestion @rieder . I don't have much experience with updating tags/releases so wasn't aware of this option. I just renamed the previous tag, which dates back...
Thanks @lwang-astro . I haven't tested the code with anything less than python 3, so I am wondering if that is the issue with the install error. Just to confirm,...
@rieder - thanks for the heads up on python 2.7. I looked at it quickly and seems like a headache and not worth it. I image going from 2.7 to...
@lwang-astro - I have pushed a new version (1.0.1) to pip. My apologies, as I thought I updated the pip version when I submitted to JOSS.
Thanks for this check @lwang-astro - I have added two ways of adding binary stars as outlined in the docs (https://clustertools.readthedocs.io/en/latest/cluster.html#the-starcluster-class). In short, you can now pass nb when adding...
@lwang-astro - interesting. My students and I all use clustertools in jupyter and I have yet to see this error. It might be a version issue, in which case i...
Hmmm, well that is interesting. So on my end I am using: matplotlib version 3.4.2 jupyter lab version 3.4.3 and I can run everything in clustertools/docs/source/notebooks/profiles.ipynb. I am not sure...
> I would definitely fold it into bridge.py, and make it optional to pass the velocities. It would also make the changes easier to spot for us :). > >...
> great! I would also put the changes in new (derived) classes in this case (and a more descriptive name than bridgev) in bridge.py. Can you also add an example...