Serhii Kulykov

Results 578 comments of Serhii Kulykov

One thing about `vaadin-badge` in the above example is that regardless of `span` or `vaadin-badge`, users would still have to use both `class` and `theme` combined for e.g. `primary` variant,...

> Do you mean inside Vaadin components? Because using them on the component instances sound perfectly fine Yes, now when we lean towards adding class based styling in V24 for...

If we want to provide the `Badge` component already in Vaadin 24.0 then I would propose to make it a Flow only component for now, as Tomi suggested. We can...

> In the batch mode, there should only be a single progressbar about the process (instead of e.g. 1000 for 1000 small files like currently) and individual files should not...

Renamed the issue accordingly to describe the suggested idea regarding the "compact" mode / single progress bar.

According to WHATWG HTML standard: https://html.spec.whatwg.org/multipage/input.html#the-readonly-attribute > Only text controls can be made read-only, since for other controls (such as checkboxes and buttons) there is no useful distinction between being...

Just to clarify: there is a logic for setting `disabled` state on individual radio buttons in the web component. Even if we decide to add `readonly` support to `vaadin-radio-button`, this...

CSS workaround to make `vaadin-radio-group` look the same as `vaadin-checkbox-group` with `readonly`: ```css vaadin-radio-group[readonly] vaadin-radio-button:not([checked]) { color: inherit; } vaadin-radio-group[readonly] vaadin-radio-button[checked]::part(radio) { background-color: var(--lumo-contrast-70pct); } vaadin-radio-group[readonly] vaadin-radio-button[checked][active]::part(radio) { transform: scale(1);...

Base styles for `[all-rows-visible]` are indeed different from Lumo in V25: https://github.com/vaadin/web-components/blob/5c73dd6cd70fb5e8d7b8db158e38fb54ce1b645e/packages/grid/src/styles/vaadin-grid-base-styles.js#L51-L57 https://github.com/vaadin/web-components/blob/5c73dd6cd70fb5e8d7b8db158e38fb54ce1b645e/packages/vaadin-lumo-styles/src/components/grid.css#L54-L60

IMO we can restore it for `[all-rows-visible]` and then consider changing the default. I can make a PR.