Serhii Kulykov

Results 575 comments of Serhii Kulykov

> make sure the fix also works in cases where the event listener is added before the web component is defined. I think we can make it work using capture...

Note: according to https://github.com/vaadin/flow-components/issues/6183#issuecomment-2046669479, some people expect to be able to listen for clicks on disabled buttons. If we fix this issue, then the linked BFP would be affected.

Thanks for the issue. The attribute is set by `FieldAriaController`, which probably needs to be updated to check for `role`.

> Not a bug, but by design how some Quill internal tags were removed to clean the html value: https://github.com/vaadin/web-components/pull/6434 I'm talking about a different logic added in #6651 and...

Updated the Quill fork to apply the workaround from https://github.com/slab/quill/issues/4509#issuecomment-2521334016, see https://github.com/vaadin/quill/commit/76a4568809fe6544ba8b4ff74c7b40f984c6850c. This replaces all but one consecutive space character with ` `, which should be less intrusive.

Updated Quill fork branch with support for ES module distribution: https://github.com/vaadin/quill/tree/vaadin-quill-v2 Tested and it works fine in dev page (and all web component tests are passing). This would enable us...

Created a PR to hide caret in visual test (I noticed one of screenshots has it): https://github.com/vaadin/web-components/pull/9924

The style is overridden here and this style on `vaadin-input-container` takes precedence over the one defined on the host element (in this case `vaadin-text-field`). IMO we should move the custom...

Note: this also applies to `vaadin-combo-box` and related components since the recent change in https://github.com/vaadin/web-components/pull/7561. BTW, the overlay also remains open after moving focus to e.g. browser address bar (which...

In Vaadin 24 we moved `vaadin-upload-file` elements to light DOM in https://github.com/vaadin/web-components/pull/4870. So they can be styled using regular CSS now.