Benjamin Alan Weaver

Results 58 comments of Benjamin Alan Weaver
trafficstars

In regards keyword-only arguments: I have converted the entire module except for the `get_images` and `get_spectra` functions, which have a fairly complicated call signature. I think that is sufficient for...

I suspect that the broken remote data test may be fixed in #2477. I also agree that an example with the data release set explicitly would be useful, and we...

What about merging #2477 first, then rebasing this PR? I think that may be easier in the long run.

@bsipocz, could you say which specific remote data test is failing? I'd like to verify that it is in fact fixed or at least not also broken in #2477.

I've been able to reproduce this. The issue is that the *input* data `large_results` is not necessarily deterministic even within a given data release, and certainly not deterministic from one...

@bsipocz, I guess the resolution to the failed test was just to mark DR17 as default? I'd still like to know the original purpose of `test_large_crossid`, if that information still...

Yes, however, this is not a _simple_ fix. There are two possible solutions: 1. Do a radial query, using the radial query API, http://skyserver.sdss.org/dr12/en/help/docs/api.aspx#search. - Advantage: it's radial! - Disadvantage:...

I'm interested in working on this, proceeding on the basis of the `fGetNearbyObjEq()` SQL as suggested in #1088. However, I have a question about the logic in `astroquery.sdss.core.SDSSClass._args_to_payload()`. Line [1015](https://github.com/astropy/astroquery/blob/f2d0bd23e0155da813cca47427a0102806cc5a30/astroquery/sdss/core.py#L1015)...