James Reeves

Results 829 comments of James Reeves

Okay, I believe I understand now. Let me think about how best to implement this. I don't think `cljfmt.lib` is the right name for the namespace, though I'm also not...

Apologies for taking a while to get back to you on this. My thought is that a separate namespace doesn't seem like the way to go. Instead, what about passing...

I think it feels different enough to warrant a separate PR, if that's okay by you.

Thanks for the proposal. So if I understand this correctly, this provides the information you'd get from `re-seq`, but with the start and end positions of each match?

Could you give some code demonstrating this use-case, and suggest any other use-cases where this functionality might be useful?

This function might be a little too specific for Medley.

I'm on the fence about this. Could you give some reasons why using `update` and `update-in` are not sufficient? ```clojure (update data :user assoc-some :name nil) (assoc-in-some data [:user :name]...

Actually, see: https://github.com/weavejester/medley/pull/72#issuecomment-1447318586. I'm thinking the same reasoning applies here: ```clojure (some->> v (assoc-in data [:account :name])) (assoc-in-some data [:account :user :name] v) ``` Given that this function would require...

> The some->> example is missing one of the keys which is why it's shorter lol. Whoops!! ```clojure (some->> v (assoc-in data [:account :user :name])) (assoc-in-some data [:account :user :name]...