W. David Dagenhart
W. David Dagenhart
please test rebased on top of 7/26/22 IB (last IB all green for IB tests) base now includes the SubProcess unit test fix so I removed the commit related to...
The unit test that fails is also failing in the IBs already. It is unrelated to the changes in this PR. It looks like everything else passed. I'm only waiting...
Matti, Chris and I had a ZOOM conversation where we were discussing this PR. Here are some changes that were suggested that seemed like improvements worth making: - Replace PauseStreamQueuesSentry...
In this comment I'm addressing iSync only. First this follows the pattern in the existing beginLumiAsync. Partially this works because in a chain the functor passed to the "first" function...
For status, the same comment applies as for iSync. For status, there is the additional question as to whether one could use std::move. std::move does not make sense for IOVSyncValue...
Yes. That is our convention. I'll change the names and add Async to them.
enable threading
please test this is probably OK to be merged without waiting for this, but maybe worth running the multi-thread tests one more time.
I'm working on these now: - DQM/EcalPreshowerMonitorModule: - DQMServices/FwkIO