cmssw
cmssw copied to clipboard
cms-sw
Resume stream queue later in releaseBeginRunResources
PR description:
Fix bug recently introduced with run concurrency PR #39673. Resume stream queue later in releaseBeginRunResources. In very rare circumstances the runStatus can be deleted before the function completes if the order is not changed. Fixes a unit test failure that showed up in the PPC architecture build.
PR validation:
Relies on existing tests.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39729/32568
- This PR adds an extra 32KB to repository
A new Pull Request was created by @wddgit (W. David Dagenhart) for master.
It involves the following packages:
- FWCore/Framework (core)
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. @makortel, @missirol this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8a4a/28248/summary.html
COMMIT: 2c332a95b157e62b82d5f6e683c8b47f5fe3e617
CMSSW: CMSSW_12_6_X_2022-10-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39729/28248/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 12 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3392309
- DQMHistoTests: Total failures: 9
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3392278
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
please test
this is probably OK to be merged without waiting for this, but maybe worth running the multi-thread tests one more time.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8a4a/28273/summary.html
COMMIT: 2c332a95b157e62b82d5f6e683c8b47f5fe3e617
CMSSW: CMSSW_12_6_X_2022-10-14-1100/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39729/28273/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /pool/condor/dir_21764/jenkins/workspace/compare-root-files-short-matrix/data/PR-3d8a4a/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc
Summary:
- No significant changes to the logs found
- Reco comparison results: 0 differences found in the comparisons
- Reco comparison had 12 failed jobs
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3391158
- DQMHistoTests: Total failures: 0
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391136
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 201 log files, 48 edm output root files, 48 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8a4a/28280/summary.html
COMMIT: 2c332a95b157e62b82d5f6e683c8b47f5fe3e617
CMSSW: CMSSW_12_6_X_2022-10-15-1100/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39729/28280/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3d8a4a/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc
Summary:
- No significant changes to the logs found
- Reco comparison results: 8 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3391158
- DQMHistoTests: Total failures: 6
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391130
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 201 log files, 48 edm output root files, 48 DQM output files
- TriggerResults: no differences found
