William Conti

Results 14 comments of William Conti

> > NodeJS tests are currently failing, as the relevant PR has not been merged yet > > I can make a informal review, but the PR needs to be...

@cbeauchesne any idea on the 4 failing python suites? I'm unsure how any of my changes could cause the `uwsgi-poc` and `uds-flask` suites to have build / run failures but...

Hi, this feature was released with [tracer version `5.2.0`](https://github.com/DataDog/dd-trace-js/releases/tag/v5.2.0)!

> Needs a test to verify the injection works correctly. Also, is support for this something we actually have consensus on and is expected to exist across _all_ languages, or...

Hi all, the fix for GRPC tracing was released with `2.8.5`. To receive tracing with grpc, please re-enable the grpc patch with `_DD_TRACE_GRPC_AIO_ENABLED=true`

Sample app branch: [conti/debug-aiopg](https://github.com/DataDog/dd-trace-py/tree/conti/debug-aiopg) The sample app has two functions, the first is untraced (though it should be traced, but `aiopg.connect` is not correctly patched). The second function uses `aiopg.connection.connect`,...

> Ok, so far LGTM. > > **BUT** :) > > Every time we rely on an external service in testing, we are prone to this service healthiness. I think...

> i guess it's still in progress? So I converted to draft. If no, please revert 😃 This is the full PR. Simply ensuring no periods and other special characters...

All system tests ci runs within each tracer's CI has been updated to include the new AWS env variables, can we get this merged?

Ive added info to the AWS authentication error message on how to setup authentication (it uses `aws-vault`, which is the DD preferred way to deal with AWS auth), should we...