Whitney Young

Results 94 comments of Whitney Young

@gajus no, it wouldn't consume 100% CPU while idle. First, `deasync` is a busy loop only in the sense that it `while (!done)` loops, but it's running the event loop...

@chrisngobanh discussion & testing really. I'm a little nervous about it because I'm not crazy about hacking at Node.js the way that `deasync` is doing in order to get things...

Yeah, this hasn't been tested on Windows. A PR would be welcome to introduce Windows support (including adding some CI service like Travis to ensure we keep things working).

I don't know that the error code corresponds, but the [IPC socket path](https://github.com/wbyoung/babel-plugin-transform-postcss/blob/654f05fdf6aa322cb34c02400e4d0b63d7062d6b/src/plugin.js#L21) seems to [require a special name on Windows](https://nodejs.org/api/net.html#net_identifying_paths_for_ipc_connections).

PR welcome… :wink:

Actually… what were you seeing happening? In theory, caching should be transparent… if you haven't changed a file, then we shouldn't recompile. Currently the cache doesn't account for config file...

I've just encountered the same issue with a build process that I configured that uses `postcss-modules`. I don't think there is a problem with `postcss-modules`, though. In fact, it seems...

Also, that's something that `underscore`/`lodash` would be able to handle if you were chaining. But right now mixing in `underscore.string` seems to break that feature. See #174.

I'm working around this with [the following simple plugin](https://gist.github.com/wbyoung/fa0192055cbca40887b449b60536a868), but I really think this logic should probably live in browserify: ```js var through = require('through2'); var setup = function(b, cb)...

If you follow the code from [here](https://github.com/GoogleCloudPlatform/k8s-node-termination-handler/blob/00ba027b5da4afae74afe76073de38ab20bf7b63/termination/gceTerminationHandler.go#L34), I'm pretty sure this does not handle manual termination.