William Burns

Results 31 comments of William Burns

Changes LGTM so far. Put on hold, until the other PR is integrated.

Looks like there is a build failure on CI. The SecureCacheImpl class needs to be updated to rename the methods.

> Just rebased. If you prefer, I can create a separate JIRA for the bugs and leave this one only with the testing stuff? Just create a separate JIRA with...

A lot of test failures now :( https://ci.infinispan.org/job/Infinispan/job/PR-10205/8/testReport/

Superseded by https://github.com/infinispan/infinispan/pull/10264

I wonder what the benefit of only returning if the key is present is? Should we not have a way to say what nodes a given key/set of keys maps...

The contains_key would be in the outer array as it should be in all nodes listed as they are owners. And actually it might be useful to say what the...

I am probably fine with the way this is implemented. It should be noted that this fix actually has nothing to do with the SQL store though and actually allows...

I am fine with this approach. @pruivo, @tristantarrant or @ryanemerson have any input?

I still am at the point of recommending we only ever return approximation to the stats endpoint. And if a user wants the exact sizer that should be a separate...