Will Browne

Results 9 comments of Will Browne

@scottlepp Apologies if I'm not following correctly, but is there a reason why we can't create the HTTP client outside of the [InstanceFactoryFunc](https://pkg.go.dev/github.com/grafana/[email protected]/backend/datasource#InstanceFactoryFunc)? Then `SFClient` could for example have the...

@marefr Feel free to test with https://github.com/grafana/grafana/pull/49709 and adjust as necessary

@kylebrandt Thanks for highlighting that Kyle. That gives us some more to dig into. But a question first - What's the current distinction between use of the `Error` field and...

>overall the approach makes sense to me for the current endpoint, but i am missing a lot of context/history. i was wondering if splitting queries into separate requests with a...

Apologies I forgot to submit this review 🤦 Will add the comment relating to the forward cookies on that PR

@Bujupah Can you share what plugins were affected? `HELP.md`/`help.md` should be still used as a fallback. @murtazaqa the change was to prioritize `README.md`/`readme.md` first, otherwise we will still try fallback...

Ah I see what's wrong - apologies for that @Bujupah. Will get a fix up and into the next 9.3 patch release

> @wbrowne and @oshirohugo - since @aangelisc is not available currently, could you please review and merge ASAP? As discussed privately with @aangelisc previously, we really need to get this...

> @wbrowne fixed lint errors and merged main in again @Jeralan Looks like there's still some issues. Once merging with `main` again, try: ``` yarn run prettier:write go work sync...